[GitHub] [spark] pan3793 commented on a diff in pull request #38985: [SPARK-41451][K8S] Avoid using empty abbrevMarker in StringUtils.abbreviate

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #38985:
URL: https://github.com/apache/spark/pull/38985#discussion_r1043983005


##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala:
##########
@@ -241,14 +241,14 @@ class KubernetesConfSuite extends SparkFunSuite {
   test("SPARK-36566: get app name label") {
     assert(KubernetesConf.getAppNameLabel(" Job+Spark-Pi 2021") === "job-spark-pi-2021")
     assert(KubernetesConf.getAppNameLabel("a" * 63) === "a" * 63)
-    assert(KubernetesConf.getAppNameLabel("a" * 64) === "a" * 63)
-    assert(KubernetesConf.getAppNameLabel("a" * 253) === "a" * 63)
+    assert(KubernetesConf.getAppNameLabel("a" * 64) === "a" * 62)

Review Comment:
   The result is correct, because `KubernetesConf#getAppNameLabel` calls `.stripSuffix("-")` after `abbreviate`
   
   ```
   scala> StringUtils.abbreviate("aaaa", "-", 3)
   res4: String = aa-
   
   scala> StringUtils.abbreviate("aaaa", "", 3).stripPrefix("-").stripSuffix("-")
   res5: String = aaa
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org