You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "kun-lu20 (via GitHub)" <gi...@apache.org> on 2023/05/23 14:02:34 UTC

[GitHub] [couchdb-docker] kun-lu20 opened a new pull request, #245: Add s390x support to CouchDB docker image

kun-lu20 opened a new pull request, #245:
URL: https://github.com/apache/couchdb-docker/pull/245

   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   Since the s390x .deb binary on debian:bullseye is released from v3.3.2 afterwards and all pre-requisites mentioned in https://github.com/apache/couchdb-docker/issues/67#issue-293689385 are available now, this PR aims to add s390x support to CouchDB docker image.
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   https://github.com/apache/couchdb-docker#how-to-use-this-image
   https://docs.couchdb.org/en/stable/intro/tour.html
   
   I've built the multi-arch docker image on an Intel VM after applying the code change in this PR and verified the generated s390x image on a s390x VM. It worked fine.
   
   ## GitHub issue number
   https://github.com/apache/couchdb-docker/issues/67
   <!-- If this is a significant change, please file a separate issue at:
        https://github.com/apache/couchdb-docker/issues
        and include the number here and in commit message(s) using
        syntax like "Fixes #472" or "Fixes apache/couchdb#472".  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] kun-lu20 commented on pull request #245: Add s390x support to CouchDB docker image

Posted by "kun-lu20 (via GitHub)" <gi...@apache.org>.
kun-lu20 commented on PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245#issuecomment-1561707265

   Hi @nickva ,
   
   Could you please take a look at this PR as well? Thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] nickva commented on pull request #245: Add s390x support to CouchDB docker image

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245#issuecomment-1561709275

   Thank you for your contribution, @kun-lu20!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] nickva merged pull request #245: Add s390x support to CouchDB docker image

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] kun-lu20 commented on pull request #245: Add s390x support to CouchDB docker image

Posted by "kun-lu20 (via GitHub)" <gi...@apache.org>.
kun-lu20 commented on PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245#issuecomment-1563515221

   Hi @nickva ,
   
   Could you please update the following file as well, so that the docker official image of CouchDB v3.3.2+ can have s390x support?
   
   https://github.com/docker-library/official-images/blob/bde595a716993f12b5bcd0476915b6bc0c17d3b4/library/couchdb#L10
   
   Thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] nickva commented on pull request #245: Add s390x support to CouchDB docker image

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245#issuecomment-1568943162

   @kun-lu20, sure thing, thanks for the reminder. I created a PR: https://github.com/docker-library/official-images/pull/14752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] kun-lu20 commented on pull request #245: Add s390x support to CouchDB docker image

Posted by "kun-lu20 (via GitHub)" <gi...@apache.org>.
kun-lu20 commented on PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245#issuecomment-1561713701

   Thanks @nickva !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-docker] kun-lu20 commented on pull request #245: Add s390x support to CouchDB docker image

Posted by "kun-lu20 (via GitHub)" <gi...@apache.org>.
kun-lu20 commented on PR #245:
URL: https://github.com/apache/couchdb-docker/pull/245#issuecomment-1568959023

   Thanks @nickva !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org