You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Jeffrey Zhong (JIRA)" <ji...@apache.org> on 2014/07/16 23:05:04 UTC
[jira] [Commented] (PHOENIX-1038) Dynamically add INDEX_TYPE column
to SYSTEM.CATALOG if not already there
[ https://issues.apache.org/jira/browse/PHOENIX-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064088#comment-14064088 ]
Jeffrey Zhong commented on PHOENIX-1038:
----------------------------------------
[~rajesh23] Have you tried the patch on adding columns to SYSTEM.CATALOG? It seems to me that the patch seems have two following issues:
1)
{code}
+ } catch (TableAlreadyExistsException ignore) {
{code}
The TableAlreadyExistsException will never be thrown in this scenario because the connection is using ClientTimeStamp=0 and the existing above comment also says
{noformat}
// A TableAlreadyExistsException is not thrown, since the table only exists *after* this fixed timestamp."
{noformat}
2) Phoenix-1095 prevent from adding new columns to SYSTEM.CATALOG which I'll fix soon.
> Dynamically add INDEX_TYPE column to SYSTEM.CATALOG if not already there
> ------------------------------------------------------------------------
>
> Key: PHOENIX-1038
> URL: https://issues.apache.org/jira/browse/PHOENIX-1038
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 5.0.0, 4.1
>
> Attachments: PHOENIX-933.patch
>
>
> When a query involves more columns to project than columns in index and query condition involves leading columns in local index then first we can get matching rowkeys from local index table and then get the required columns from data table. In local index both data region and index region co-reside in the same RS, we can call get on data region to get the missing columns in the index, without any n/w overhead. So it's efficient.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: [jira] [Commented] (PHOENIX-1038) Dynamically add INDEX_TYPE
column to SYSTEM.CATALOG if not already there
Posted by James Taylor <ja...@apache.org>.
I have a fix for this attached here:
https://issues.apache.org/jira/browse/PHOENIX-1016
<https://issues.apache.org/jira/browse/PHOENIX-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel>
On Wednesday, July 16, 2014, Jeffrey Zhong (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/PHOENIX-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064088#comment-14064088
> ]
>
> Jeffrey Zhong commented on PHOENIX-1038:
> ----------------------------------------
>
> [~rajesh23] Have you tried the patch on adding columns to SYSTEM.CATALOG?
> It seems to me that the patch seems have two following issues:
> 1)
> {code}
> + } catch (TableAlreadyExistsException ignore) {
> {code}
> The TableAlreadyExistsException will never be thrown in this scenario
> because the connection is using ClientTimeStamp=0 and the existing above
> comment also says
> {noformat}
> // A TableAlreadyExistsException is not thrown, since the table only
> exists *after* this fixed timestamp."
> {noformat}
> 2) Phoenix-1095 prevent from adding new columns to SYSTEM.CATALOG which
> I'll fix soon.
>
>
> > Dynamically add INDEX_TYPE column to SYSTEM.CATALOG if not already there
> > ------------------------------------------------------------------------
> >
> > Key: PHOENIX-1038
> > URL: https://issues.apache.org/jira/browse/PHOENIX-1038
> > Project: Phoenix
> > Issue Type: Sub-task
> > Reporter: rajeshbabu
> > Assignee: rajeshbabu
> > Fix For: 5.0.0, 4.1
> >
> > Attachments: PHOENIX-933.patch
> >
> >
> > When a query involves more columns to project than columns in index and
> query condition involves leading columns in local index then first we can
> get matching rowkeys from local index table and then get the required
> columns from data table. In local index both data region and index region
> co-reside in the same RS, we can call get on data region to get the missing
> columns in the index, without any n/w overhead. So it's efficient.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
>