You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/08/05 16:14:21 UTC
Review Request 50856: GEODE-225 excessive CPU utilization and garbage
collection strain for JSON processing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50856/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Bugs: GEODE-225
https://issues.apache.org/jira/browse/GEODE-225
Repository: geode
Description
-------
Use of a static ObjectMapper can be enabled by setting the system property
PdxInstance.use-static-mapper=true
We can switch to always using a static ObjectMapper once multithreaded performance is determined to not be affected.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java d759c49155f2c098b0d7ad48129045c4eb819ea8
Diff: https://reviews.apache.org/r/50856/diff/
Testing
-------
precheckin
Thanks,
Bruce Schuchardt
Re: Review Request 50856: GEODE-225 excessive CPU utilization and
garbage collection strain for JSON processing
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50856/#review144941
-----------------------------------------------------------
how about keeping ObjectMapper in threadLocal?
- Hitesh Khamesra
On Aug. 5, 2016, 4:14 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50856/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2016, 4:14 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-225
> https://issues.apache.org/jira/browse/GEODE-225
>
>
> Repository: geode
>
>
> Description
> -------
>
> Use of a static ObjectMapper can be enabled by setting the system property
>
> PdxInstance.use-static-mapper=true
>
> We can switch to always using a static ObjectMapper once multithreaded performance is determined to not be affected.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java d759c49155f2c098b0d7ad48129045c4eb819ea8
>
> Diff: https://reviews.apache.org/r/50856/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 50856: GEODE-225 excessive CPU utilization and
garbage collection strain for JSON processing
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50856/#review144963
-----------------------------------------------------------
Fix it, then Ship it!
This is just a suggestion. I didn't see any logic errors in the current code
geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java (line 73)
<https://reviews.apache.org/r/50856/#comment211116>
It looks like the "mapper" static is only used if USE_STATIC_MAPPER is true.
How about changing the code to something like this:
static final ObjectMapper mapper = USE_STATIC_MAPPER ? createObjectMapper() : null;
private static ObjectMapper createObjectMapper() {
ObjectMapper result = new ObjectMapper();
// do the result init
return result;
}
geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java (line 233)
<https://reviews.apache.org/r/50856/#comment211117>
This would be:
objMapper = createObjectMapper();
- Darrel Schneider
On Aug. 5, 2016, 9:14 a.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50856/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2016, 9:14 a.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-225
> https://issues.apache.org/jira/browse/GEODE-225
>
>
> Repository: geode
>
>
> Description
> -------
>
> Use of a static ObjectMapper can be enabled by setting the system property
>
> PdxInstance.use-static-mapper=true
>
> We can switch to always using a static ObjectMapper once multithreaded performance is determined to not be affected.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java d759c49155f2c098b0d7ad48129045c4eb819ea8
>
> Diff: https://reviews.apache.org/r/50856/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>