You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/08/30 12:42:04 UTC
[activemq-artemis] branch new-logging updated (b1972df1bd -> 705e44c923)
This is an automated email from the ASF dual-hosted git repository.
robbie pushed a change to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
discard b1972df1bd add note
discard f56c08a6d8 action some TODOs, add some others
discard be2846755a some notes around reload
discard 1c44336657 remove a couple TODOs not needed
discard b95e6537f4 fixups after rebase to main at a0f39a4b28545f4010e07d950c34fe9f1f228b68
discard 5da4034281 fixup header comments
discard ad9a87329c fix some file references and update notes
discard b511fc0f31 convert some more test loggers
discard 46e20cc1c4 remove slf4j->jbl bridge from example
discard 8e5b7b3495 replace a couple of examples logging.properties that enable audit logger output
discard 66068edfbb add a note
discard 3a58f7759d remove exclusion that is no longer needed
discard 9bf7a77402 switch another logger missed previously
discard cd03a018e4 fixups after rebase to main at 0ca44c0e6972991cf80e5feda34f6d02cf94dea0
discard 27ea87c579 remove uses of JBL from compatibility tests, add artemis-unit-test-support to snapshots CP to ensure test appender class is found and avoids stacktracing
discard b6876892a1 add another TODO note
discard 7aaacb231f move another old log config file out to root, for any later comparisons needed
discard 55dcc48ee1 replace logging.properties files for e2e-tests server configs
discard 1a0ae6e5cd remove commons-logging slf4j bridge now the karaf bits dont cause beanutils log spam
discard a68b237de1 move karaf server feature test to its own module, its logging deps mess with the commons-config handling
discard 7f9b32215a delete old Log4J 1.x log4j.properties files that shouldnt be doing anything, build isnt using log4j 1.x / reload4j anymore
discard 86fd14a2a5 update deps to match actual SLF4J base usage and simplify
discard e24ee1591d use latest log4j version
discard a2eaa2436b remove now-unused import
discard a68beaeb49 update notes
discard 4cf4509264 remove rather than reinstate a couple of unnecesarry level manipulations
discard 2ca71ee641 ensure method or class based cleanups for AssertionLoggerHandler exist or will be effective, where startCapture() has been called previously
discard e42aced782 reinstate another test manipulating levels
discard 64c0022db3 restore one of the remaining tests using JBL, manipulating levels
discard 5ef9745dec Revert "add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc"
discard f9a0969ca7 Revert "Moving dependencies as test"
discard 2fd8ab3a55 Revert "Remove slf4j bridge depedencies from libs", towards getting build back to consistent deps state and to more easily revert original addition leading to issue.
discard c0a106b92a fixing build after rebase
discard 094d7e83dd Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
discard 1c779b7ef3 fixing test
discard acd1f1c91b Moving dependencies as test
discard bc2bf539c2 Remove slf4j bridge depedencies from libs
discard c961460263 Removing log facade package
discard 4a8932f5e0 make start on updating remaining integration tests, manipulating levels etc
discard 43745a6f5c remove various mentions of jblm and wildfly-common from scripts etc, update service config logging details..now to see what it breaks
discard 8c4a1c29c0 also move the old main tests logging.config file
discard 2d1c05ae76 move old base logging.properties out of artemis-cli, but leave it in root for comparison to see needed config updates as others replaced
discard be2418b136 add some TODOs for area cleanup still needed
discard 671ce1ec3d change remaining integration tests except those with TODOs
discard 7a0d9803f0 Adding safeguard against {?} on LogProcessor
discard 606be9ddc9 fix compile issues IDE somehow decided not to show
discard 888980f435 more test changes
discard 01cb8e7df6 more test updates
discard bc953c7709 some more integration test updates
discard 25fa9e34d5 make start on updating integration tests
discard 3508dcfba5 add note about e2e-test fixups needed
discard 6d178d8034 add artemis-unit-test-support dep to various modules that have tests, avoid stacktrace on not finding appender from shared logging config
discard a34a6fc9a9 Verifying JMX Security and setting up javax.management.builder.initial before Log4J starts its own JMX
discard 3ef2834baf add artemis-unit-test-support dep to various modules that have tests, and will stacktrace if the appender isnt found which is referenced in their shared logging test config
discard 9b30c8c905 fix dep scope
discard a560fe4a0f add note about many integration-tests etc still using JBL
discard 96aa2a4d1e fix other files similar to commit titled 'Fixing duplicate properties'
discard bdda5e079a Fixing duplicate properties
discard 92f49baab5 Setting version as 3.0.0
discard e8dd376eac updating version after rebasing
discard 8ee8db528f add log config to get NettyNativeTest working
discard 8ad7caca31 simplify test logging config again, adjust assertion to be more specific and take into account change in output from 07329118c10d14bce018a580b0dadbcf081233a8
discard 4549f6dcc3 add log config for AuditLoggerAMQPMutualSSLTest
discard 38d202b07d ARTEMIS-3902 Adding Reason to Security Exception
discard 55fe44d938 add some TODO notes from memory
discard b75b99893b add some [in-flux] config to get more failing audit log smoke tests passing
discard 63dd977aab apply needed change only, and remove old unused logging.properties file
discard 3e1433bac3 reset smoke test config to current base assembly config
discard af68da2a23 some more helper additions to bring default assembly logging config into line with prior config
discard 0e3b7afdbd Adding a test with no argument on exception (just to be sure)
discard 5a79df2bf2 Removing @Cause annotation
discard 5c9d3f8b8c fix up errorprone error and an IDE warning
discard 8f748d3aca ensure exceptions/causes are the last arg passed, as the logging framework expects, and processor now enforces
discard 3525059f7c fix checkstyle on processor
discard a34f664829 small tweak on test
discard 7cfe7e40b2 Enforcing exception as the last argument
discard 68b9d5e510 log processing improvement with exceptions
discard 4771bad90b flesh out assembly default logging config, give output like previous behaviour
discard c8f2f5db05 Removing Reload4J
discard 74a4dd33ce fix some more placeholders missed previously
discard 46096f642a make basic start on audit log file config, add [unfinished] config changes to get AuditLoggerResourceTest smoke test passing
discard 2ce1591b9d reorder args to match previously out-of-order placeholders, ensure new output matches previous
discard 739437af89 remove now-unnecessary quote escaping from log/message bundle format strings, giving same output as before switch to slf4j formatter
discard d768705059 switch to released 2.0.0 artemis-native dep
discard 972dcdb74e Fixing up some {0} versus {}
discard e70d1dabef re-enable GHA CI runs in the main repo, build now in state it can pass the PR test subset (except for d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it fail)
discard 816cf43fde add TODO for another fun task
discard ef3e1417f4 fix various test failures due to unexpected message string; also make some tests indicate why they failed
discard 6a88806a06 temporarily remove test to allow concentrating on other issues
discard a1b742333b fix test missed in prior change
discard ef06c3eeff fix format of code prefix in messages, pointed out by failing test
discard 0576d2e6d7 make a start on a basic loging config for distribution
discard 92ad83f4a9 add some more needed deps; essentially every module with tests (or without specific log test config) will need this to avoid a stacktrace from logging setup issues
discard d5f59a4434 avoid NPE in a unit test due to audit loggers still being enabled, unlike prior test logging config
discard 0f5309c812 Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
discard 171a794a7f add some deps needed/used already, look into test failure
discard 14e179b19a fixup for release profile following prior rebases+squashes
discard cd51ba0dba add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc
discard 4d207b2027 basic logging config and some more on AssertionLoggerHandler to get some tests using it working
discard a60680caa7 make a start on restoring AssertionLoggerHandler to get tests going
discard 9b357387d1 Artemis native at 2.0 snapshot
discard 1f18f75a96 squashed logging changes from Clebert + me, rebased onto main at 688b894c6205058c24d225b340aea1d8a5599902
add 755b987ab1 ARTEMIS-3958 sending LWT may recurse infinitely if disk full
add 3fee038f85 This closes #4190
add 0e56d1a567 ARTEMIS-3961 don't log OperationContext
add fcd9ff2a86 This closes #4193
add aa4c642796 NO-JIRA Fixing intermittent failure in StompV11Test
new 5a76648b85 squashed logging changes from Clebert + me, rebased onto main at aa4c64279602fb4448e77ccde3beb05ea32c03b2
new 6d261dce79 Artemis native at 2.0 snapshot
new 8027a40ab3 make a start on restoring AssertionLoggerHandler to get tests going
new 5a5a9d9676 basic logging config and some more on AssertionLoggerHandler to get some tests using it working
new 518b7af4f1 add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc
new a76674be0b fixup for release profile following prior rebases+squashes
new 6c2ca55c2a add some deps needed/used already, look into test failure
new f7bfb96d81 Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
new 225a67c408 avoid NPE in a unit test due to audit loggers still being enabled, unlike prior test logging config
new bab796ecea add some more needed deps; essentially every module with tests (or without specific log test config) will need this to avoid a stacktrace from logging setup issues
new b994ca3944 make a start on a basic loging config for distribution
new f66089649f fix format of code prefix in messages, pointed out by failing test
new db2edee5d7 fix test missed in prior change
new ffa46d23a5 temporarily remove test to allow concentrating on other issues
new 40f4124689 fix various test failures due to unexpected message string; also make some tests indicate why they failed
new 6e1b9b8169 add TODO for another fun task
new a7304508dd re-enable GHA CI runs in the main repo, build now in state it can pass the PR test subset (except for d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it fail)
new 132284d640 Fixing up some {0} versus {}
new b81204c392 switch to released 2.0.0 artemis-native dep
new fdff9c4054 remove now-unnecessary quote escaping from log/message bundle format strings, giving same output as before switch to slf4j formatter
new 544ae5fd17 reorder args to match previously out-of-order placeholders, ensure new output matches previous
new 2d8cce72e6 make basic start on audit log file config, add [unfinished] config changes to get AuditLoggerResourceTest smoke test passing
new a788129d63 fix some more placeholders missed previously
new f6f84de622 Removing Reload4J
new 1dddddd9bb flesh out assembly default logging config, give output like previous behaviour
new 33b17ffc3c log processing improvement with exceptions
new 466dbd9b4c Enforcing exception as the last argument
new bd2951cb71 small tweak on test
new c4ff428616 fix checkstyle on processor
new cebf03bbc2 ensure exceptions/causes are the last arg passed, as the logging framework expects, and processor now enforces
new 71250bd1bf fix up errorprone error and an IDE warning
new 287e2b407b Removing @Cause annotation
new 98c2180b1d Adding a test with no argument on exception (just to be sure)
new b4690ce403 some more helper additions to bring default assembly logging config into line with prior config
new 61f114131b reset smoke test config to current base assembly config
new 0f70e85911 apply needed change only, and remove old unused logging.properties file
new 2254e3e64f add some [in-flux] config to get more failing audit log smoke tests passing
new 1d4cb2e57e add some TODO notes from memory
new 10428405a1 ARTEMIS-3902 Adding Reason to Security Exception
new da5fa985e9 add log config for AuditLoggerAMQPMutualSSLTest
new db144ee949 simplify test logging config again, adjust assertion to be more specific and take into account change in output from 07329118c10d14bce018a580b0dadbcf081233a8
new 45f542207e add log config to get NettyNativeTest working
new a2fc3602fc updating version after rebasing
new 63866dd5e5 Setting version as 3.0.0
new dab7a9eedc Fixing duplicate properties
new c212d79474 fix other files similar to commit titled 'Fixing duplicate properties'
new d191e9cc7f add note about many integration-tests etc still using JBL
new 7e9d13055b fix dep scope
new 68417f218f add artemis-unit-test-support dep to various modules that have tests, and will stacktrace if the appender isnt found which is referenced in their shared logging test config
new eac53c8794 Verifying JMX Security and setting up javax.management.builder.initial before Log4J starts its own JMX
new 1bfa00c60a add artemis-unit-test-support dep to various modules that have tests, avoid stacktrace on not finding appender from shared logging config
new 36ba2df56b add note about e2e-test fixups needed
new ab1a61abeb make start on updating integration tests
new b12908e9a6 some more integration test updates
new 849014649c more test updates
new 823264bc46 more test changes
new 4673a705b2 fix compile issues IDE somehow decided not to show
new 7777021f98 Adding safeguard against {?} on LogProcessor
new e100ebf3dc change remaining integration tests except those with TODOs
new f55511a916 add some TODOs for area cleanup still needed
new 55ade183b5 move old base logging.properties out of artemis-cli, but leave it in root for comparison to see needed config updates as others replaced
new 8b0b2cb019 also move the old main tests logging.config file
new a8c19bef4f remove various mentions of jblm and wildfly-common from scripts etc, update service config logging details..now to see what it breaks
new 1a73958586 make start on updating remaining integration tests, manipulating levels etc
new 84e0a119f4 Removing log facade package
new 4b99ed1c9f Remove slf4j bridge depedencies from libs
new c0d96e5579 Moving dependencies as test
new 16aa01a0ed fixing test
new e763a93e4c Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
new 379e15816b fixing build after rebase
new a8703ae54d Revert "Remove slf4j bridge depedencies from libs", towards getting build back to consistent deps state and to more easily revert original addition leading to issue.
new 633b321df8 Revert "Moving dependencies as test"
new b9b82cbf97 Revert "add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc"
new f13e1a988a restore one of the remaining tests using JBL, manipulating levels
new 23f79edd33 reinstate another test manipulating levels
new b4a5d84578 ensure method or class based cleanups for AssertionLoggerHandler exist or will be effective, where startCapture() has been called previously
new 5cc4bd5991 remove rather than reinstate a couple of unnecesarry level manipulations
new c9139c7d8d update notes
new e3f34c231b remove now-unused import
new e5ed95943e use latest log4j version
new a9ba9a6b56 update deps to match actual SLF4J base usage and simplify
new b2e9b7c67b delete old Log4J 1.x log4j.properties files that shouldnt be doing anything, build isnt using log4j 1.x / reload4j anymore
new f76ad54558 move karaf server feature test to its own module, its logging deps mess with the commons-config handling
new 4f5216a514 remove commons-logging slf4j bridge now the karaf bits dont cause beanutils log spam
new b75cac2558 replace logging.properties files for e2e-tests server configs
new 11b18a707d move another old log config file out to root, for any later comparisons needed
new 04fa3cd4e2 add another TODO note
new cea6dc0e67 remove uses of JBL from compatibility tests, add artemis-unit-test-support to snapshots CP to ensure test appender class is found and avoids stacktracing
new f8cafeac25 fixups after rebase to main at 0ca44c0e6972991cf80e5feda34f6d02cf94dea0
new 7c898839c3 switch another logger missed previously
new 35e9611a7e remove exclusion that is no longer needed
new 1d2706e6b2 add a note
new 84aa84c2b6 replace a couple of examples logging.properties that enable audit logger output
new 1905610a19 remove slf4j->jbl bridge from example
new ea14b95d6c convert some more test loggers
new 4d627ff12f fix some file references and update notes
new 6c0f82f37f fixup header comments
new e67929be77 fixups after rebase to main at a0f39a4b28545f4010e07d950c34fe9f1f228b68
new 50d6271984 remove a couple TODOs not needed
new 28fe4c006f some notes around reload
new 78aabef68f action some TODOs, add some others
new 705e44c923 add note
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (b1972df1bd)
\
N -- N -- N refs/heads/new-logging (705e44c923)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 102 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../core/protocol/mqtt/MQTTProtocolManager.java | 4 +-
.../artemis/core/protocol/mqtt/MQTTSession.java | 46 +++++++++++-----------
.../core/protocol/mqtt/MQTTSessionState.java | 42 +++++++++++++++++---
.../core/paging/impl/PagingManagerImpl.java | 7 ++++
.../impl/journal/OperationContextImpl.java | 10 +----
.../core/server/impl/ActiveMQServerImpl.java | 2 +-
.../plugin/impl/LoggingActiveMQServerPlugin.java | 2 +-
.../impl/LoggingActiveMQServerPluginLogger.java | 6 +--
.../paging/impl/PagingManagerImplAccessor.java | 11 ++----
.../artemis/tests/integration/mqtt5/MQTT5Test.java | 21 ++++++++++
.../tests/integration/stomp/v11/StompV11Test.java | 4 +-
11 files changed, 99 insertions(+), 56 deletions(-)
copy artemis-cli/src/main/java/org/apache/activemq/artemis/cli/CLIException.java => tests/integration-tests/src/test/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImplAccessor.java (78%)