You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/12 18:03:00 UTC

[jira] [Commented] (AIRFLOW-1671) Missing @apply_defaults annotation for gcs download operator

    [ https://issues.apache.org/jira/browse/AIRFLOW-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741345#comment-16741345 ] 

ASF GitHub Bot commented on AIRFLOW-1671:
-----------------------------------------

mik-laj commented on pull request #4498: [AIRFLOW-1671] Add missing @apply_defaukts decorators
URL: https://github.com/apache/airflow/pull/4498
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-1671
   
   ### Description
   
   - [ ] Adds missing decorators.
   
   ### Tests
   
   - [ ] No operator has a test that could check it. The change would have to take place globally.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Missing @apply_defaults annotation for gcs download operator
> ------------------------------------------------------------
>
>                 Key: AIRFLOW-1671
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1671
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.9.0
>            Reporter: Joy Gao
>            Assignee: Joy Gao
>            Priority: Major
>             Fix For: 1.9.0
>
>
> The @apply_defaults annotation appear to be accidentally removed in a previous PR. Should be added back. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)