You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by luissilvaos <gi...@git.apache.org> on 2017/07/24 09:27:41 UTC
[GitHub] cordova-ios pull request #328: CB-13093: (iOS) Infinite looping when stressi...
GitHub user luissilvaos opened a pull request:
https://github.com/apache/cordova-ios/pull/328
CB-13093: (iOS) Infinite looping when stressing navigation
### Platforms affected
iOS
### What does this PR do?
Fix the navigations that starts with the STATE_WAITING_FOR_LOAD_START by calling the self webview:didFailLoadWithError method instead of delegating it.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/luissilvaos/cordova-ios CB-13093
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit 138e58649a9b698d6a2fb2454497981d7b937669
Author: Luis Silva <lu...@outsystems.com>
Date: 2017-07-24T09:14:51Z
CB-13093: (iOS) Infinite looping when stressing navigation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/328
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/328?src=pr&el=h1) Report
> Merging [#328](https://codecov.io/gh/apache/cordova-ios/pull/328?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/8edd13aaee16d6996a4560a74d17798437b42c6f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/328?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 63.97% 63.97%
=======================================
Files 14 14
Lines 1674 1674
Branches 277 277
=======================================
Hits 1071 1071
Misses 603 603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/328?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/328?src=pr&el=footer). Last update [8edd13a...138e586](https://codecov.io/gh/apache/cordova-ios/pull/328?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...
Posted by luissilvaos <gi...@git.apache.org>.
Github user luissilvaos commented on the issue:
https://github.com/apache/cordova-ios/pull/328
Yes, it is. Please check my last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/328
Thanks for the PR. Is this issue reproducible by a unit test? See https://github.com/apache/cordova-ios/blob/master/tests/CordovaLibTests/CDVWebViewDelegateTests.m
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org