You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yuj <gi...@git.apache.org> on 2018/06/12 19:36:54 UTC
[GitHub] spark pull request #21544: add one supported type missing from the javadoc
GitHub user yuj opened a pull request:
https://github.com/apache/spark/pull/21544
add one supported type missing from the javadoc
## What changes were proposed in this pull request?
The supported java.math.BigInteger type is not mentioned in the javadoc of Encoders.bean()
## How was this patch tested?
only Javadoc fix
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuj/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21544.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21544
----
commit 635378aa616f535ee77a3ac9d4236d54c7ef093e
Author: James Yu <ja...@...>
Date: 2018-06-12T19:32:19Z
add one supported type missing from the javadoc
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21544: add one supported type missing from the javadoc
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21544
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21544: add one supported type missing from the javadoc
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21544
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21544: add one supported type missing from the javadoc
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21544
It's okay but mind double checking this file to see if there's any typo or misleading information while we are here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21544: add one supported type missing from the javadoc
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21544
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21544: add one supported type missing from the javadoc
Posted by yuj <gi...@git.apache.org>.
Github user yuj commented on the issue:
https://github.com/apache/spark/pull/21544
@HyukjinKwon I double checked, and there is nothing else that needs to be fixed here in this file.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21544: add one supported type missing from the javadoc
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21544
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21544: add one supported type missing from the javadoc
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21544
Thanks. Merging in master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org