You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/13 01:03:02 UTC
[GitHub] [cordova-eslint] breautek opened a new pull request #18: Npmrc
breautek opened a new pull request #18:
URL: https://github.com/apache/cordova-eslint/pull/18
Progresses https://github.com/apache/cordova/issues/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-eslint] breautek merged pull request #18: chore: npmrc
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #18:
URL: https://github.com/apache/cordova-eslint/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-eslint] erisu commented on pull request #18: chore: npmrc
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #18:
URL: https://github.com/apache/cordova-eslint/pull/18#issuecomment-921768322
Oh, it seems that this PR was based off another branch which also has its own PR.
I wonder if this PR should be based off master instead since the other PR is a major change and will require a major release. While this could go into a patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-eslint] erisu commented on a change in pull request #18: chore: npmrc
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #18:
URL: https://github.com/apache/cordova-eslint/pull/18#discussion_r711022254
##########
File path: package.json
##########
@@ -18,9 +18,9 @@
"author": "Apache Software Foundation",
"license": "Apache-2.0",
"dependencies": {
- "eslint": "^6.8.0",
+ "eslint": "^7.21.0",
Review comment:
Why was this changed?
##########
File path: package.json
##########
@@ -18,9 +18,9 @@
"author": "Apache Software Foundation",
"license": "Apache-2.0",
"dependencies": {
- "eslint": "^6.8.0",
+ "eslint": "^7.21.0",
"eslint-config-standard": "^14.1.1",
- "eslint-plugin-import": "^2.20.1",
+ "eslint-plugin-import": "^2.22.1",
Review comment:
Why was this changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-eslint] breautek commented on pull request #18: chore: npmrc
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #18:
URL: https://github.com/apache/cordova-eslint/pull/18#issuecomment-921769783
Yah I'll rebase. I didn't realise I branched off of another branch instead of master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org