You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/05/18 04:05:51 UTC

[GitHub] [openwhisk] style95 commented on a change in pull request #4898: Change AcknowledegmentMessage interface

style95 commented on a change in pull request #4898:
URL: https://github.com/apache/openwhisk/pull/4898#discussion_r426359359



##########
File path: core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/CommonLoadBalancer.scala
##########
@@ -283,7 +288,7 @@ abstract class CommonLoadBalancer(config: WhiskConfig,
         totalActivationMemory.add(entry.memoryLimit.toMB * (-1))
         activationsPerNamespace.get(entry.namespaceId).foreach(_.decrement())
 
-        releaseInvoker(invoker, entry)
+        invoker.foreach(releaseInvoker(_, entry))

Review comment:
       👍 
   
   If this is to use some methods of `CommonLoadBalancer` in the downstream, isn't there any other methods to be updated as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org