You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Patrick Dreyer (JIRA)" <ji...@apache.org> on 2010/12/15 07:57:01 UTC
[jira] Created: (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Unable to extract a TAR file that contains sparse entries
---------------------------------------------------------
Key: COMPRESS-124
URL: https://issues.apache.org/jira/browse/COMPRESS-124
Project: Commons Compress
Issue Type: New Feature
Components: Archivers
Affects Versions: 1.1, 1.2
Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
Reporter: Patrick Dreyer
Fix For: 1.2
Good news first: I already have the patch ready for that.
I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Issue Comment Edited] (COMPRESS-124) Unable to extract a
TAR file that contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069901#comment-13069901 ]
Stefan Bodewig edited comment on COMPRESS-124 at 7/23/11 5:04 AM:
------------------------------------------------------------------
svn revisions 1149798 and 1149799 hold the major part of Patrick's original patch, I've left out the doc changes for now and overridden canReadEntryData
was (Author: bodewig):
svn revision 1149798 and 1149799 hold the major part of Patrick's original patch, I've left out the doc changes for now and overridden canReadEntryData
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Dreyer updated COMPRESS-124:
------------------------------------
Description:
Good news first: I already have the patch ready for that.
I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
The TAR files in question have all been VMware Diagnostic File bundles.
See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
was:
Good news first: I already have the patch ready for that.
I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070325#comment-13070325 ]
Stefan Bodewig commented on COMPRESS-124:
-----------------------------------------
A tar archive using the oldgnu format has been committed as part of the tests for COMPRESS-145.
svn revision 1150556 adds test-archives for the three different POSIX variants supported by GNU tar.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971612#action_12971612 ]
Torsten Curdt commented on COMPRESS-124:
----------------------------------------
Great contribution. Thanks.
For this to go into 1.2 (IMO) we will have to fix "reading an archive with sparse files and writing those files leads to invalid output files" first though.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981670#action_12981670 ]
Patrick Dreyer commented on COMPRESS-124:
-----------------------------------------
I have to thank that I could base my work on the existing implementation.
Actually, I was rather surprised about the high quality code. One doesn't find such fine crafted open-source code each day. My compliments to all contributors!
Recognizing sparse files and reading their sparse blocks was not that hard, but correctly writing such during exporting will be more complicated to to.
Thus, unfortunately I won't find the time to implement correct sparse file export and I'm more than happy that I can at least kind of "skip" them.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069901#comment-13069901 ]
Stefan Bodewig commented on COMPRESS-124:
-----------------------------------------
svn revision 1149798 holds the major part of Patrick's original patch, I've left out the doc changes for now and overridden canReadEntryData
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (COMPRESS-124) Unable to extract a TAR
file that contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971567#action_12971567 ]
Patrick Dreyer edited comment on COMPRESS-124 at 12/15/10 2:36 AM:
-------------------------------------------------------------------
Including not only the source but as well the documentation and changes.xml
Unfortunately, I was not able to generate a test TAR archive containing sparse files, even invoking GNU Tar with "--sparse" and all the TAR archives I have with such sparse files, contain information I'm not allowed disclose.
If someone is able to generate a TAR archive containing sparse files and provide such, pleas let me know so I can include the necessary unit tests.
was (Author: patrickdreyer):
Including not only the source but as well the documentation and changes.xml
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Issue Comment Edited] (COMPRESS-124) Unable to extract a
TAR file that contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071536#comment-13071536 ]
Patrick Dreyer edited comment on COMPRESS-124 at 7/27/11 6:01 AM:
------------------------------------------------------------------
I absolutely agree with overwriting {{canReadEntryData()}} instead having {{isGNUSparse()}}.
Looking at the commits, we still have no unit tests, right?
was (Author: patrickdreyer):
I absolutely agree with overwriting {{canReadEntryData()}} instead having {{isGNUSparse()}}.
Looking at the commits, we still have no unit tests, right?
And, Stefan, you mentioned the commit of a tar archive using the oldgnu format, but where is it?
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071552#comment-13071552 ]
Patrick Dreyer commented on COMPRESS-124:
-----------------------------------------
Stefan, there is only one thing for me to say: Thank you.
First, for incorporating my patch and second for writing the unit tests on my behalf.
I look forward using the official release containing the tar sparse support, instead depending any longer on our own internal fork.
We are using the patch since I created this issue and never had any issues with it, it just works as expected.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071546#comment-13071546 ]
Stefan Bodewig commented on COMPRESS-124:
-----------------------------------------
We do have a unit test now, I just forgot to add the JIRA issue to the commit message so it doesn't show up in the subversion commits panel, sorry. The tar archive in question: svn revision 1150549 http://svn.apache.org/viewvc?view=revision&revision=1150549 - unit test svn revision 1150551 http://svn.apache.org/viewvc?view=revision&revision=1150551
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Dreyer updated COMPRESS-124:
------------------------------------
Attachment: gnuSparseFile.patch
Including not only the source but as well the documentation and changes.xml
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Issue Comment Edited] (COMPRESS-124) Unable to extract a
TAR file that contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069901#comment-13069901 ]
Stefan Bodewig edited comment on COMPRESS-124 at 7/23/11 5:04 AM:
------------------------------------------------------------------
svn revision 1149798 and 1149799 hold the major part of Patrick's original patch, I've left out the doc changes for now and overridden canReadEntryData
was (Author: bodewig):
svn revision 1149798 holds the major part of Patrick's original patch, I've left out the doc changes for now and overridden canReadEntryData
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069557#comment-13069557 ]
Stefan Bodewig commented on COMPRESS-124:
-----------------------------------------
Actually canReadEntryData is defined in ArchiveInputStream and should be overriden in TarArchiveInputStream to return false on sparse entries.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Patrick Dreyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071536#comment-13071536 ]
Patrick Dreyer commented on COMPRESS-124:
-----------------------------------------
I absolutely agree with overwriting {{canReadEntryData()}} instead having {{isGNUSparse()}}.
Looking at the commits, we still have no unit tests, right?
And, Stefan, you mentioned the commit of a tar archive using the oldgnu format, but where is it?
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Bodewig updated COMPRESS-124:
------------------------------------
Fix Version/s: (was: 1.2)
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COMPRESS-124) Unable to extract a TAR file that
contains sparse entries
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069551#comment-13069551 ]
Stefan Bodewig commented on COMPRESS-124:
-----------------------------------------
So if I read the patch correctly it means a user would check the isGNUSparse() flag on each entry and skip those that are, right?
In a way this is similar to ZipArchiveInputStream's canReadEntryData method that users can check, maybe we should add a similar one to TarArchiveInputStream as well.
> Unable to extract a TAR file that contains sparse entries
> ---------------------------------------------------------
>
> Key: COMPRESS-124
> URL: https://issues.apache.org/jira/browse/COMPRESS-124
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.1, 1.2
> Environment: Platform independent. However, I'm currently using Window 7 Enterprise.
> Reporter: Patrick Dreyer
> Fix For: 1.2
>
> Attachments: gnuSparseFile.patch
>
>
> Good news first: I already have the patch ready for that.
> I got several TAR files which I could not extract with any of the existing Java implementations, but I could extract all those TAR files successfully with GNU tar.
> It turned out that all the failing TAR files contained so called sparse files. Investigating the source code of all existing Java TAR implementations showed me that none of them even recognizes the existence of GNU sparse entries.
> Actually, I don't need to process one of the contained sparse files and I'm happy if I'm at least able to correctly untar all the non-sparsed files. Thus, it would be sufficient recognizing sparse files without the need to correctly un-sparse them while extracting. As long as all non-sparsed files get extracted correctly, I'm fine.
> The TAR files in question have all been VMware Diagnostic File bundles.
> See http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=653 to know how to get them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira