You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/04/10 19:32:06 UTC
[GitHub] metron pull request #986: METRON-1518 Build Failure When Using Profile HDP-2...
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/986
METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
The build fails when using the 'HDP-2.5.0.0' profile.
```
/Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:45:
error: cannot find symbol
import org.apache.storm.StormTimer;
^
symbol: class StormTimer
location: package org.apache.storm
/Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:167:
error: cannot find symbol
private StormTimer expiredFlushTimer;
^
symbol: class StormTimer
location: class ProfileBuilderBolt
/Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:450:
error: cannot find symbol
private StormTimer createTimer(String name) {
^
symbol: class StormTimer
location: class ProfileBuilderBolt
```
This was caused by my PR; #977. That code relied on a class that is only available in Storm 1.0.3+. When using the Maven profile `HDP-2.5.0.0`, the code is built against Storm 1.0.1.
### Changes
* This completely removes the use of a`StormTimer`. There is no need for it. I had thought it would help me drive testing, but it has not ended up being useful at all.
* An executor is used to drive a separate thread which flushes expired profiles on a regular basis.
* Updated the Travis CI builds so they are run with the HDP-2.5.0.0 profile. This ensures that the CI tests are run against the same version of Storm as the development environments are built against. This will help ensure we catch similar issues in the future.
### Manual Testing
* Run a development environment and ensure that alerts are visible in the Alerts UI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1518
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #986
----
commit 0c012fc8cfa6314dfc30c7d372970f1d68bfd908
Author: Nick Allen <ni...@...>
Date: 2018-04-10T12:46:47Z
METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
----
---
[GitHub] metron issue #986: METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/986
+1 ship it
---
[GitHub] metron pull request #986: METRON-1518 Build Failure When Using Profile HDP-2...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/986#discussion_r180544522
--- Diff: .travis.yml ---
@@ -33,7 +33,7 @@ before_install:
- npm config set prefix $HOME/.npm-prefix --global
install:
- - time mvn -q -T 2C -DskipTests clean install
+ - time mvn -q -T 2C -DskipTests -PHDP-2.5.0.0 clean install
--- End diff --
Just so I'm completely clear, by "build matrix" I mean [this](https://docs.travis-ci.com/user/customizing-the-build#Build-Matrix)
---
[GitHub] metron pull request #986: METRON-1518 Build Failure When Using Profile HDP-2...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/986
---
[GitHub] metron issue #986: METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/986
Thanks for the reviews. Just to be sure, I ran up the CentOS dev environment, validated that alerts are being created, created a profile and made sure that values were written.
---
[GitHub] metron pull request #986: METRON-1518 Build Failure When Using Profile HDP-2...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/986#discussion_r180547851
--- Diff: .travis.yml ---
@@ -33,7 +33,7 @@ before_install:
- npm config set prefix $HOME/.npm-prefix --global
install:
- - time mvn -q -T 2C -DskipTests clean install
+ - time mvn -q -T 2C -DskipTests -PHDP-2.5.0.0 clean install
--- End diff --
That works.
---
[GitHub] metron issue #986: METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/986
+1 by inspection, thanks!
---
[GitHub] metron pull request #986: METRON-1518 Build Failure When Using Profile HDP-2...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/986#discussion_r180543990
--- Diff: .travis.yml ---
@@ -33,7 +33,7 @@ before_install:
- npm config set prefix $HOME/.npm-prefix --global
install:
- - time mvn -q -T 2C -DskipTests clean install
+ - time mvn -q -T 2C -DskipTests -PHDP-2.5.0.0 clean install
--- End diff --
I believe the rationale for having travis run without the 2.5.0.0 profile and full-dev build with it is to ensure that we build with both per PR (since both are required for a +1). I would be more comfortable with a follow-on task to make a proper travis matrix where both are run in travis per build.
---