You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/04/25 10:27:17 UTC

[GitHub] [sling-org-apache-sling-starter] kwin commented on a diff in pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

kwin commented on code in PR #153:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153#discussion_r1176319050


##########
src/main/features/boot.json:
##########
@@ -84,6 +84,14 @@
             "id":"org.apache.felix:org.apache.felix.log:1.2.6",
             "start-order":"1"
         },
+        {
+            "id":"org.eclipse.parsson:jakarta.json:1.1.1",

Review Comment:
   What is this artifact? Shouldn't we rather reference the official API dependency, https://search.maven.org/artifact/jakarta.json/jakarta.json-api/2.1.1/jar according to https://jakarta.ee/specifications/jsonp/2.1/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org