You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/20 14:54:44 UTC
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4642: Dsstats math fix
mitchell852 commented on a change in pull request #4642:
URL: https://github.com/apache/trafficcontrol/pull/4642#discussion_r411444904
##########
File path: traffic_ops/traffic_ops_golang/trafficstats/deliveryservice.go
##########
@@ -277,7 +277,8 @@ func getDSSummary(client *influx.Client, conf *tc.TrafficDSStatsConfig, db strin
value := float64(s.Count*60) * s.Average
if conf.MetricType == "kbps" {
Review comment:
so the Perl was actually "like" kbps. Should we maintain parity with Perl for 1.x?
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/Extensions/TrafficStats/Delegate/Statistics.pm#L184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org