You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "superdiaodiao (via GitHub)" <gi...@apache.org> on 2024/01/23 08:40:14 UTC
[PR] [fix](function) fix ipv4 function get failed error [doris]
superdiaodiao opened a new pull request, #30269:
URL: https://github.com/apache/doris/pull/30269
## Proposed changes
Issue Number: close #xxx
Function related:
- **ipv4_string_to_num**
- **ipv4_string_to_num_or_default**
<!--Describe your changes.-->
In the past, when ipv4_string_to_num or ipv4_string_to_num_or_default handled with the **NULL** input, we got this error:

In this PR, we fix it, which is making ipv4_string_to_num throw an **exception** and ipv4_string_to_num_or_default return **0**.

## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908175180
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909746207
<details>
<summary>TPC-DS: <b>Total hot run time: 185971 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fd28e3011f5452ee3a46afbcef07db73aa461a72, data reload: false
query1 938 328 322 322
query2 6581 1967 1888 1888
query3 6699 200 210 200
query4 30712 22072 22146 22072
query5 4447 365 445 365
query6 254 155 149 149
query7 4604 262 253 253
query8 225 192 175 175
query9 8414 2593 2590 2590
query10 414 234 203 203
query11 16863 15404 15569 15404
query12 127 65 65 65
query13 1682 373 384 373
query14 10595 6907 7001 6907
query15 213 182 180 180
query16 5816 252 262 252
query17 939 467 467 467
query18 1780 245 247 245
query19 175 132 130 130
query20 67 68 66 66
query21 192 133 123 123
query22 4930 4798 4780 4780
query23 31585 30787 30848 30787
query24 11562 2849 2788 2788
query25 557 315 297 297
query26 1063 137 138 137
query27 3208 288 280 280
query28 6763 1831 1815 1815
query29 1144 613 602 602
query30 279 136 141 136
query31 963 729 757 729
query32 87 48 48 48
query33 700 201 205 201
query34 1159 459 466 459
query35 881 777 768 768
query36 1343 1225 1225 1225
query37 93 63 57 57
query38 3365 3244 3226 3226
query39 1300 1251 1267 1251
query40 196 88 79 79
query41 38 35 33 33
query42 102 75 82 75
query43 500 527 485 485
query44 1103 688 691 688
query45 192 173 176 173
query46 1050 661 659 659
query47 1555 1506 1548 1506
query48 376 307 295 295
query49 1123 280 285 280
query50 675 310 318 310
query51 5281 5218 5209 5209
query52 84 77 75 75
query53 315 276 259 259
query54 231 173 177 173
query55 76 73 73 73
query56 169 155 157 155
query57 1026 942 887 887
query58 184 153 147 147
query59 2872 2636 2694 2636
query60 207 176 183 176
query61 82 82 79 79
query62 616 359 349 349
query63 285 262 260 260
query64 4880 1767 1782 1767
query65 3324 3260 3247 3247
query66 1197 317 302 302
query67 15757 15123 15115 15115
query68 12832 535 505 505
query69 619 282 291 282
query70 1706 1494 1487 1487
query71 10476 10195 10193 10193
query72 5070 2814 2868 2814
query73 2930 313 311 311
query74 7565 6379 6411 6379
query75 5234 2279 2293 2279
query76 6732 1063 1025 1025
query77 676 219 225 219
query78 9588 9012 8492 8492
query79 1025 494 500 494
query80 558 320 311 311
query81 470 194 197 194
query82 198 79 73 73
query83 135 114 116 114
query84 272 65 70 65
query85 1077 332 330 330
query86 394 396 377 377
query87 3507 3343 3419 3343
query88 3181 2195 2188 2188
query89 430 368 342 342
query90 2001 184 180 180
query91 149 117 131 117
query92 57 42 47 42
query93 1406 447 403 403
query94 1237 154 152 152
query95 488 443 434 434
query96 610 322 321 321
query97 4276 4155 4167 4155
query98 192 187 182 182
query99 976 661 697 661
Total cold run time: 302282 ms
Total hot run time: 185971 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909755223
<details>
<summary>ClickBench: <b>Total hot run time: 31.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fd28e3011f5452ee3a46afbcef07db73aa461a72, data reload: false
query1 0.03 0.03 0.03
query2 0.05 0.02 0.02
query3 0.22 0.04 0.05
query4 1.71 0.06 0.06
query5 0.54 0.52 0.52
query6 1.27 0.64 0.62
query7 0.02 0.01 0.01
query8 0.03 0.02 0.02
query9 0.57 0.50 0.50
query10 0.56 0.56 0.55
query11 0.11 0.09 0.08
query12 0.10 0.09 0.09
query13 0.61 0.61 0.61
query14 0.79 0.80 0.81
query15 0.80 0.76 0.78
query16 0.36 0.39 0.39
query17 1.04 1.00 1.03
query18 0.23 0.21 0.27
query19 1.86 1.69 1.78
query20 0.02 0.01 0.01
query21 15.41 0.56 0.56
query22 2.80 2.66 2.55
query23 17.33 0.79 0.70
query24 2.36 1.63 1.61
query25 0.33 0.29 0.19
query26 0.64 0.13 0.14
query27 0.06 0.05 0.05
query28 10.37 0.78 0.76
query29 12.51 3.17 3.19
query30 0.57 0.45 0.51
query31 2.77 0.34 0.36
query32 3.38 0.48 0.49
query33 3.23 3.23 3.20
query34 15.90 4.33 4.22
query35 4.33 4.32 4.25
query36 1.12 1.06 1.05
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.02
query40 0.16 0.13 0.12
query41 0.07 0.01 0.02
query42 0.02 0.02 0.02
query43 0.02 0.02 0.02
Total cold run time: 104.43 s
Total hot run time: 31.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905783886
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905800821
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905945869
<details>
<summary>ClickBench: <b>Total hot run time: 30.97 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9d6c88d45ef0ec6fcb750f95f5ad8580fc314ea, data reload: false
query1 0.03 0.03 0.02
query2 0.07 0.02 0.03
query3 0.22 0.05 0.04
query4 1.69 0.07 0.08
query5 0.54 0.52 0.52
query6 1.30 0.63 0.62
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.55 0.50 0.49
query10 0.57 0.56 0.58
query11 0.12 0.08 0.09
query12 0.11 0.10 0.08
query13 0.61 0.61 0.61
query14 0.80 0.81 0.79
query15 0.79 0.79 0.79
query16 0.40 0.40 0.36
query17 1.00 1.02 1.01
query18 0.25 0.24 0.26
query19 1.90 1.78 1.77
query20 0.01 0.01 0.01
query21 15.42 0.57 0.55
query22 2.56 2.06 2.06
query23 17.47 0.83 0.83
query24 2.50 1.03 0.91
query25 0.39 0.40 0.10
query26 0.35 0.13 0.14
query27 0.06 0.05 0.04
query28 11.09 0.75 0.74
query29 12.54 3.32 3.20
query30 0.56 0.49 0.47
query31 2.78 0.34 0.35
query32 3.35 0.49 0.50
query33 3.21 3.19 3.24
query34 15.69 4.23 4.29
query35 4.38 4.33 4.27
query36 1.12 1.07 1.08
query37 0.06 0.04 0.04
query38 0.03 0.03 0.03
query39 0.03 0.01 0.01
query40 0.16 0.12 0.12
query41 0.07 0.02 0.01
query42 0.03 0.01 0.01
query43 0.02 0.01 0.02
Total cold run time: 104.89 s
Total hot run time: 30.97 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908143290
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit dfa73ebb9abb5a108e104e46853ed8839413ee88 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.6 seconds inserted 10000000 Rows, about 735K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909954708
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909674301
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909673708
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909724841
<details>
<summary>TPC-H: <b>Total hot run time: 38890 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fd28e3011f5452ee3a46afbcef07db73aa461a72, data reload: false
------ Round 1 ----------------------------------
q1 17668 5598 5374 5374
q2 2042 140 137 137
q3 10718 1149 1185 1149
q4 10249 729 815 729
q5 7731 3193 3136 3136
q6 201 121 119 119
q7 862 491 482 482
q8 9230 1923 1944 1923
q9 7294 6421 6349 6349
q10 8264 3026 3000 3000
q11 410 209 202 202
q12 356 189 189 189
q13 18004 3340 3353 3340
q14 241 211 208 208
q15 545 521 494 494
q16 459 362 387 362
q17 947 537 515 515
q18 7491 6954 6849 6849
q19 1613 1414 1329 1329
q20 547 311 313 311
q21 2773 2395 2425 2395
q22 368 314 298 298
Total cold run time: 108013 ms
Total hot run time: 38890 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5539 5397 5202 5202
q2 329 215 214 214
q3 3349 3218 3202 3202
q4 2085 2084 2037 2037
q5 6049 5867 5931 5867
q6 194 114 118 114
q7 2348 1839 1919 1839
q8 3234 3367 3379 3367
q9 8899 8783 8790 8783
q10 3901 3830 3802 3802
q11 554 458 456 456
q12 797 648 627 627
q13 16902 3146 3129 3129
q14 289 262 258 258
q15 554 504 513 504
q16 504 459 443 443
q17 1897 1837 1845 1837
q18 9535 19009 9822 9822
q19 24919 1580 1550 1550
q20 4612 1918 1944 1918
q21 14507 5608 5762 5608
q22 940 549 540 540
Total cold run time: 111937 ms
Total hot run time: 61119 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1912127074
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905933313
<details>
<summary>TPC-DS: <b>Total hot run time: 186198 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9d6c88d45ef0ec6fcb750f95f5ad8580fc314ea, data reload: false
query1 941 333 328 328
query2 6542 2071 1917 1917
query3 6736 197 197 197
query4 30667 22149 22067 22067
query5 4456 429 447 429
query6 248 157 154 154
query7 4620 269 267 267
query8 224 173 175 173
query9 8463 2599 2560 2560
query10 424 229 221 221
query11 16812 15571 15380 15380
query12 127 68 65 65
query13 1688 388 379 379
query14 10495 6897 6920 6897
query15 207 185 191 185
query16 5787 253 245 245
query17 957 480 479 479
query18 1795 263 255 255
query19 171 132 126 126
query20 71 73 75 73
query21 193 128 121 121
query22 4838 4872 4696 4696
query23 31873 30854 30763 30763
query24 12582 2827 2812 2812
query25 557 318 311 311
query26 1826 146 143 143
query27 3216 291 287 287
query28 7022 1841 1847 1841
query29 2123 644 616 616
query30 278 142 138 138
query31 963 751 785 751
query32 79 52 53 52
query33 714 222 209 209
query34 1154 464 461 461
query35 903 789 771 771
query36 1358 1254 1242 1242
query37 96 58 56 56
query38 3346 3265 3208 3208
query39 1316 1254 1280 1254
query40 347 89 87 87
query41 39 36 35 35
query42 96 78 88 78
query43 505 483 472 472
query44 1100 689 687 687
query45 197 179 174 174
query46 1072 640 640 640
query47 1585 1583 1497 1497
query48 376 324 327 324
query49 1217 284 292 284
query50 673 307 303 303
query51 5317 5200 5235 5200
query52 88 76 77 76
query53 321 267 254 254
query54 240 190 190 190
query55 82 70 88 70
query56 183 171 172 171
query57 1033 920 957 920
query58 192 168 159 159
query59 2953 2752 2746 2746
query60 213 186 183 183
query61 82 88 80 80
query62 624 359 360 359
query63 284 261 257 257
query64 6122 1776 1767 1767
query65 3330 3278 3235 3235
query66 1437 317 320 317
query67 15473 14899 15169 14899
query68 12525 537 509 509
query69 611 302 302 302
query70 1760 1515 1542 1515
query71 10481 10211 10204 10204
query72 4888 2808 2842 2808
query73 2789 307 314 307
query74 7056 6345 6382 6345
query75 5268 2320 2349 2320
query76 6682 1025 1035 1025
query77 743 234 238 234
query78 9271 8566 8628 8566
query79 1058 491 510 491
query80 581 327 315 315
query81 464 222 201 201
query82 197 80 82 80
query83 151 116 115 115
query84 276 68 69 68
query85 1128 330 324 324
query86 390 399 381 381
query87 3605 3317 3364 3317
query88 3121 2144 2145 2144
query89 460 350 351 350
query90 1975 183 181 181
query91 154 122 125 122
query92 53 44 48 44
query93 1493 425 421 421
query94 1262 158 158 158
query95 502 450 465 450
query96 615 312 313 312
query97 4261 4152 4165 4152
query98 217 192 194 192
query99 1029 709 652 652
Total cold run time: 306115 ms
Total hot run time: 186198 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905896272
<details>
<summary>TPC-H: <b>Total hot run time: 39121 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9d6c88d45ef0ec6fcb750f95f5ad8580fc314ea, data reload: false
------ Round 1 ----------------------------------
q1 18068 5405 6046 5405
q2 2655 147 139 139
q3 11531 1211 1178 1178
q4 10771 781 835 781
q5 7848 3276 3194 3194
q6 200 125 126 125
q7 892 517 499 499
q8 9237 1992 1985 1985
q9 7778 6360 6361 6360
q10 8241 3046 3060 3046
q11 416 219 201 201
q12 355 186 185 185
q13 17999 3391 3348 3348
q14 236 219 216 216
q15 539 512 517 512
q16 432 371 373 371
q17 938 522 535 522
q18 7617 6821 6755 6755
q19 1592 1302 1455 1302
q20 621 304 288 288
q21 2841 2403 2498 2403
q22 370 313 306 306
Total cold run time: 111177 ms
Total hot run time: 39121 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5494 5309 5232 5232
q2 339 217 204 204
q3 3336 3214 3195 3195
q4 2051 2082 2041 2041
q5 5916 5960 5987 5960
q6 197 117 118 117
q7 2393 1959 1920 1920
q8 3218 3366 3379 3366
q9 9284 9048 8716 8716
q10 3922 3814 3860 3814
q11 550 451 448 448
q12 801 612 615 612
q13 16944 3171 3158 3158
q14 286 248 268 248
q15 553 502 506 502
q16 520 465 459 459
q17 1862 1848 1836 1836
q18 9470 19281 9687 9687
q19 24773 1547 1538 1538
q20 4610 1942 1911 1911
q21 14552 5446 5423 5423
q22 972 511 569 511
Total cold run time: 112043 ms
Total hot run time: 60898 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908104247
TeamCity be ut coverage result:
Function Coverage: 36.27% (8608/23734)
Line Coverage: 28.38% (70476/248330)
Region Coverage: 27.36% (36367/132927)
Branch Coverage: 24.16% (18644/77164)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dfa73ebb9abb5a108e104e46853ed8839413ee88_dfa73ebb9abb5a108e104e46853ed8839413ee88/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908049611
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905579129
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905803031
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905952923
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit f9d6c88d45ef0ec6fcb750f95f5ad8580fc314ea with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.2 seconds inserted 10000000 Rows, about 704K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1910070691
<details>
<summary>ClickBench: <b>Total hot run time: 31.18 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4e873a27d266bd352c1bbd82d1f4ba24c16f866c, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.03 0.02
query3 0.23 0.05 0.05
query4 1.69 0.07 0.07
query5 0.53 0.52 0.52
query6 1.34 0.65 0.63
query7 0.02 0.02 0.01
query8 0.03 0.02 0.02
query9 0.54 0.50 0.51
query10 0.56 0.55 0.56
query11 0.11 0.08 0.08
query12 0.11 0.10 0.09
query13 0.61 0.61 0.60
query14 0.79 0.82 0.79
query15 0.78 0.77 0.79
query16 0.36 0.38 0.36
query17 0.95 1.02 1.01
query18 0.23 0.25 0.24
query19 1.77 1.74 1.86
query20 0.01 0.00 0.01
query21 15.43 0.60 0.58
query22 2.52 2.37 1.79
query23 17.22 0.86 0.83
query24 2.35 1.25 1.36
query25 0.39 0.18 0.19
query26 0.62 0.13 0.14
query27 0.06 0.07 0.05
query28 10.91 0.79 0.78
query29 12.64 3.08 3.22
query30 0.53 0.55 0.54
query31 2.78 0.34 0.35
query32 3.37 0.48 0.48
query33 3.20 3.24 3.24
query34 15.76 4.26 4.27
query35 4.38 4.24 4.33
query36 1.11 1.08 1.07
query37 0.06 0.06 0.05
query38 0.04 0.03 0.02
query39 0.03 0.01 0.02
query40 0.16 0.13 0.13
query41 0.07 0.02 0.02
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 104.42 s
Total hot run time: 31.18 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909675709
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1912127023
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4_string_to_num(_or_default) get failed error, improve ipv6_string_to_num code and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1907915696
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909961573
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30269:
URL: https://github.com/apache/doris/pull/30269#discussion_r1463077330
##########
be/src/vec/functions/function_ip.h:
##########
@@ -343,7 +336,8 @@ class FunctionIPv6NumToString : public IFunction {
};
namespace detail {
-template <IPExceptionMode exception_mode, typename ToColumn = ColumnIPv6, typename StringColumnType>
+template <IPConvertExceptionMode exception_mode, typename ToColumn = ColumnIPv6,
+ typename StringColumnType>
Review Comment:
warning: function 'convertToIPv6' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
ColumnPtr convertToIPv6(const StringColumnType& string_column,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_ip.h:339:** 136 lines including whitespace and comments (threshold 80)
```cpp
ColumnPtr convertToIPv6(const StringColumnType& string_column,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908128161
<details>
<summary>TPC-DS: <b>Total hot run time: 186609 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dfa73ebb9abb5a108e104e46853ed8839413ee88, data reload: false
query1 945 340 338 338
query2 6576 1987 2095 1987
query3 6694 200 200 200
query4 30936 22292 22083 22083
query5 4457 457 363 363
query6 246 155 150 150
query7 4620 261 269 261
query8 234 177 182 177
query9 8332 2553 2517 2517
query10 429 233 235 233
query11 16950 15600 15465 15465
query12 123 72 68 68
query13 1685 382 383 382
query14 10538 6899 7004 6899
query15 214 183 180 180
query16 5785 254 255 254
query17 944 483 473 473
query18 1783 264 253 253
query19 175 132 131 131
query20 73 74 68 68
query21 188 129 129 129
query22 4936 4746 4748 4746
query23 31930 30812 30936 30812
query24 12534 2805 2845 2805
query25 575 307 308 307
query26 1822 143 150 143
query27 3221 290 290 290
query28 7210 1836 1810 1810
query29 2147 630 621 621
query30 285 138 134 134
query31 956 739 739 739
query32 88 52 50 50
query33 712 209 210 209
query34 1170 459 481 459
query35 860 749 751 749
query36 1273 1161 1149 1149
query37 133 61 59 59
query38 3343 3252 3208 3208
query39 1310 1271 1260 1260
query40 345 93 85 85
query41 39 36 35 35
query42 89 80 83 80
query43 537 474 468 468
query44 1097 685 689 685
query45 200 180 178 178
query46 1078 640 636 636
query47 1644 1542 1555 1542
query48 386 309 310 309
query49 1210 295 278 278
query50 689 306 319 306
query51 5368 5177 5216 5177
query52 94 89 76 76
query53 321 262 255 255
query54 243 181 195 181
query55 84 80 81 80
query56 185 171 168 168
query57 1035 922 934 922
query58 190 168 166 166
query59 2963 2807 2789 2789
query60 212 200 190 190
query61 84 86 89 86
query62 632 350 372 350
query63 276 263 266 263
query64 6131 1784 1727 1727
query65 3348 3248 3249 3248
query66 1450 327 324 324
query67 15980 15196 15180 15180
query68 10210 542 517 517
query69 592 304 303 303
query70 1682 1550 1490 1490
query71 10451 10200 10201 10200
query72 4134 2833 2852 2833
query73 2029 312 314 312
query74 6962 6503 6432 6432
query75 4514 2310 2331 2310
query76 6264 1035 1008 1008
query77 726 227 236 227
query78 8985 8892 8490 8490
query79 1045 499 485 485
query80 731 343 323 323
query81 467 210 207 207
query82 325 80 74 74
query83 174 119 123 119
query84 281 70 71 70
query85 1208 357 333 333
query86 394 412 399 399
query87 3505 3362 3318 3318
query88 3371 2173 2159 2159
query89 399 357 359 357
query90 1993 190 186 186
query91 153 123 132 123
query92 54 44 44 44
query93 2545 431 423 423
query94 1229 165 159 159
query95 497 456 448 448
query96 626 321 313 313
query97 4243 4119 4176 4119
query98 215 192 182 182
query99 1114 702 701 701
Total cold run time: 303460 ms
Total hot run time: 186609 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905578603
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "superdiaodiao (via GitHub)" <gi...@apache.org>.
superdiaodiao commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908174271
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905792718
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1910080337
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4e873a27d266bd352c1bbd82d1f4ba24c16f866c with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 14.5 seconds inserted 10000000 Rows, about 689K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1910023515
<details>
<summary>TPC-H: <b>Total hot run time: 38723 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4e873a27d266bd352c1bbd82d1f4ba24c16f866c, data reload: false
------ Round 1 ----------------------------------
q1 17654 5634 5226 5226
q2 2048 143 131 131
q3 10729 1138 1173 1138
q4 10259 765 774 765
q5 7724 3105 3172 3105
q6 198 125 125 125
q7 876 482 484 482
q8 9213 1917 1939 1917
q9 7219 6373 6351 6351
q10 8209 3023 3038 3023
q11 417 192 199 192
q12 352 189 194 189
q13 17987 3351 3361 3351
q14 247 212 228 212
q15 550 531 505 505
q16 441 368 383 368
q17 943 604 495 495
q18 7304 6842 6922 6842
q19 3475 1444 1341 1341
q20 582 294 309 294
q21 2757 2370 2440 2370
q22 364 301 302 301
Total cold run time: 109548 ms
Total hot run time: 38723 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5502 5248 5236 5236
q2 319 219 209 209
q3 3333 3301 3138 3138
q4 2090 2039 2030 2030
q5 6001 5977 5771 5771
q6 200 112 114 112
q7 2302 1867 1830 1830
q8 3244 3372 3381 3372
q9 8871 8939 8743 8743
q10 3936 3858 3859 3858
q11 555 467 444 444
q12 864 632 625 625
q13 16927 3147 3139 3139
q14 293 248 277 248
q15 546 499 500 499
q16 493 478 449 449
q17 1872 1866 1825 1825
q18 9528 16899 9520 9520
q19 27020 1548 1545 1545
q20 4608 1951 1931 1931
q21 14459 5470 5311 5311
q22 959 542 533 533
Total cold run time: 113922 ms
Total hot run time: 60368 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908137720
<details>
<summary>ClickBench: <b>Total hot run time: 31.25 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dfa73ebb9abb5a108e104e46853ed8839413ee88, data reload: false
query1 0.03 0.02 0.02
query2 0.06 0.02 0.03
query3 0.22 0.05 0.05
query4 1.70 0.08 0.06
query5 0.53 0.52 0.53
query6 1.29 0.72 0.66
query7 0.02 0.01 0.01
query8 0.04 0.03 0.02
query9 0.55 0.50 0.49
query10 0.57 0.55 0.57
query11 0.11 0.08 0.08
query12 0.12 0.09 0.08
query13 0.61 0.62 0.61
query14 0.76 0.84 0.79
query15 0.79 0.77 0.78
query16 0.38 0.39 0.37
query17 1.01 1.03 1.05
query18 0.25 0.24 0.26
query19 1.87 1.80 1.79
query20 0.01 0.01 0.01
query21 15.40 0.58 0.58
query22 2.12 2.54 2.15
query23 17.64 0.87 0.69
query24 2.35 1.15 1.17
query25 0.48 0.22 0.16
query26 0.51 0.13 0.13
query27 0.06 0.05 0.05
query28 11.66 0.77 0.76
query29 12.52 3.12 3.16
query30 0.54 0.49 0.48
query31 2.79 0.35 0.35
query32 3.38 0.48 0.49
query33 3.23 3.19 3.25
query34 15.70 4.22 4.30
query35 4.31 4.29 4.27
query36 1.10 1.06 1.07
query37 0.06 0.04 0.04
query38 0.04 0.03 0.03
query39 0.02 0.02 0.01
query40 0.16 0.13 0.12
query41 0.07 0.02 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 105.1 s
Total hot run time: 31.25 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #30269:
URL: https://github.com/apache/doris/pull/30269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905582345
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 function get failed error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1905958344
TeamCity be ut coverage result:
Function Coverage: 36.76% (8667/23575)
Line Coverage: 28.73% (70749/246249)
Region Coverage: 27.61% (36457/132024)
Branch Coverage: 24.34% (18656/76662)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f9d6c88d45ef0ec6fcb750f95f5ad8580fc314ea_f9d6c88d45ef0ec6fcb750f95f5ad8580fc314ea/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1908107627
<details>
<summary>TPC-H: <b>Total hot run time: 38785 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dfa73ebb9abb5a108e104e46853ed8839413ee88, data reload: false
------ Round 1 ----------------------------------
q1 17672 5271 5346 5271
q2 2034 139 135 135
q3 10639 1139 1167 1139
q4 10230 793 820 793
q5 7721 3166 3112 3112
q6 196 123 124 123
q7 855 486 481 481
q8 9222 1917 1963 1917
q9 7276 6392 6344 6344
q10 8220 3044 3073 3044
q11 420 216 208 208
q12 360 194 193 193
q13 17993 3377 3333 3333
q14 245 215 225 215
q15 554 526 492 492
q16 422 385 381 381
q17 935 529 464 464
q18 7485 6857 6793 6793
q19 1590 1354 1360 1354
q20 599 306 281 281
q21 2808 2404 2444 2404
q22 371 308 316 308
Total cold run time: 107847 ms
Total hot run time: 38785 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5421 5210 5089 5089
q2 321 212 214 212
q3 3376 3238 3271 3238
q4 2120 2021 1976 1976
q5 5882 6021 5922 5922
q6 203 117 122 117
q7 2243 1889 1817 1817
q8 3258 3378 3373 3373
q9 8904 8855 8693 8693
q10 3942 3820 3822 3820
q11 558 462 468 462
q12 795 630 636 630
q13 16935 3200 3134 3134
q14 288 263 274 263
q15 542 502 496 496
q16 521 474 460 460
q17 1875 1854 1856 1854
q18 9654 17643 9448 9448
q19 25032 1571 1533 1533
q20 4629 1938 1942 1938
q21 14422 5230 5380 5230
q22 994 544 551 544
Total cold run time: 111915 ms
Total hot run time: 60249 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1907958859
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1909760474
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit fd28e3011f5452ee3a46afbcef07db73aa461a72 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 14.7 seconds inserted 10000000 Rows, about 680K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix ipv4 funcs get failed error, improve an ipv6 func and exception message [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30269:
URL: https://github.com/apache/doris/pull/30269#issuecomment-1910045817
<details>
<summary>TPC-DS: <b>Total hot run time: 186507 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4e873a27d266bd352c1bbd82d1f4ba24c16f866c, data reload: false
query1 939 328 323 323
query2 6593 1901 2019 1901
query3 6705 210 202 202
query4 32845 22315 22162 22162
query5 4458 441 366 366
query6 247 154 148 148
query7 4598 264 256 256
query8 223 176 173 173
query9 8425 2591 2578 2578
query10 408 226 239 226
query11 16876 15562 15521 15521
query12 122 70 70 70
query13 1676 379 379 379
query14 10589 7035 6979 6979
query15 214 176 173 173
query16 5803 253 251 251
query17 958 464 461 461
query18 1783 251 260 251
query19 172 130 126 126
query20 72 69 66 66
query21 187 133 128 128
query22 4887 4844 4779 4779
query23 31625 30749 30739 30739
query24 11522 2792 2799 2792
query25 538 312 306 306
query26 902 143 147 143
query27 2858 290 286 286
query28 6329 1845 1818 1818
query29 979 615 614 614
query30 279 136 146 136
query31 921 750 745 745
query32 82 56 46 46
query33 697 217 212 212
query34 1127 453 447 447
query35 887 760 794 760
query36 1280 1190 1234 1190
query37 94 62 57 57
query38 3356 3286 3208 3208
query39 1316 1258 1245 1245
query40 195 85 78 78
query41 37 36 35 35
query42 83 81 82 81
query43 523 457 494 457
query44 1064 695 703 695
query45 189 176 171 171
query46 1071 658 661 658
query47 1572 1590 1593 1590
query48 377 302 303 302
query49 1105 286 285 285
query50 708 313 303 303
query51 5313 5146 5174 5146
query52 85 81 74 74
query53 318 252 257 252
query54 232 181 177 177
query55 93 79 77 77
query56 179 163 169 163
query57 1017 951 946 946
query58 174 149 149 149
query59 2691 2730 2711 2711
query60 204 178 178 178
query61 88 84 83 83
query62 606 357 357 357
query63 277 263 254 254
query64 4579 1807 1757 1757
query65 3340 3264 3273 3264
query66 1179 321 309 309
query67 15690 15382 14949 14949
query68 12558 548 524 524
query69 598 299 286 286
query70 1725 1473 1393 1393
query71 10481 10200 10191 10191
query72 5074 2846 2849 2846
query73 2768 318 315 315
query74 6963 6441 6471 6441
query75 5136 2338 2312 2312
query76 6758 1043 1035 1035
query77 661 222 237 222
query78 9093 8790 8684 8684
query79 1001 491 505 491
query80 606 324 309 309
query81 481 203 202 202
query82 201 74 73 73
query83 136 111 118 111
query84 274 67 69 67
query85 1091 332 322 322
query86 382 367 403 367
query87 3474 3368 3340 3340
query88 3115 2192 2189 2189
query89 440 346 354 346
query90 2002 184 187 184
query91 158 121 129 121
query92 57 43 48 43
query93 1469 429 440 429
query94 1266 158 158 158
query95 496 463 447 447
query96 611 317 319 317
query97 4228 4128 4175 4128
query98 202 197 177 177
query99 981 673 683 673
Total cold run time: 301047 ms
Total hot run time: 186507 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org