You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "aremily (via GitHub)" <gi...@apache.org> on 2023/08/27 15:41:10 UTC
[GitHub] [commons-crypto] aremily opened a new pull request, #242: Set MacOS Runner to 11 and Fix Unknown Method Error
aremily opened a new pull request, #242:
URL: https://github.com/apache/commons-crypto/pull/242
Did a fork and build to get reacclimatized to the code base. A few observations. One, the build contained an unknown method error. Two, the test matrix was pulling macos-latest, which used OpenSSL3 and broke the tests. Three, the CI pipeline isn't running the full set of tests. This PR addresses the first two issues. I'm not sure what the rationale was for running only a small subset of tests in GitHub actions, but we may want to consider running them all, at least in some of the matrix builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] aremily commented on pull request #242: Set MacOS Runner to 11 and Fix Unknown Method Error
Posted by "aremily (via GitHub)" <gi...@apache.org>.
aremily commented on PR #242:
URL: https://github.com/apache/commons-crypto/pull/242#issuecomment-1694700880
Including the console output for the unit tests.
[test_output.txt](https://github.com/apache/commons-crypto/files/12448334/test_output.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] codecov-commenter commented on pull request #242: Set MacOS Runner to 11 and Fix Unknown Method Error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #242:
URL: https://github.com/apache/commons-crypto/pull/242#issuecomment-1712461271
## [Codecov](https://app.codecov.io/gh/apache/commons-crypto/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#242](https://app.codecov.io/gh/apache/commons-crypto/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f700eed) into [master](https://app.codecov.io/gh/apache/commons-crypto/commit/26b8ffbb97e69a5d4d2ad96cc95e426329943cb0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (26b8ffb) will **decrease** coverage by `0.39%`.
> Report is 11 commits behind head on master.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #242 +/- ##
============================================
- Coverage 75.04% 74.65% -0.39%
+ Complexity 448 445 -3
============================================
Files 38 38
Lines 1823 1823
Branches 181 181
============================================
- Hits 1368 1361 -7
- Misses 341 348 +7
Partials 114 114
```
| [Files Changed](https://app.codecov.io/gh/apache/commons-crypto/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...g/apache/commons/crypto/utils/ReflectionUtils.java](https://app.codecov.io/gh/apache/commons-crypto/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL3V0aWxzL1JlZmxlY3Rpb25VdGlscy5qYXZh) | `91.66% <100.00%> (ø)` | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/commons-crypto/pull/242/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] sebbASF merged pull request #242: Set MacOS Runner to 11 and Fix Unknown Method Error
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF merged PR #242:
URL: https://github.com/apache/commons-crypto/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org