You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Fernando Ribeiro <no...@github.com> on 2016/03/20 21:35:31 UTC
[jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for Zaqar
(#938)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/938
-- Commit Summary --
* JCLOUDS-1095: Update OpenStack KeyStone Support for Zaqar
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/ServiceType.java (4)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (4)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/internal/BaseOpenStackMockTest.java (2)
M apis/openstack-keystone/src/test/resources/keystoneAuthResponse.json (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/938.patch
https://github.com/jclouds/jclouds/pull/938.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Ignasi Barrera <no...@github.com>.
@zack-shoylev WDYT?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-199846613
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Zack Shoylev <no...@github.com>.
@nacx I think it has to be "deprecated" (or documented as such) before it is removed in a major release, like everything else.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-199855724
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Ignasi Barrera <no...@github.com>.
Hmmm now that I see both PRs together, it looks like this change is needed to change the *default* value for the service type in the Marconi API, as done in https://github.com/jclouds/jclouds-labs-openstack/pull/204.
I agree to keep the current constant and mark it as deprecated, but also keep the PR that changes the default service type in Marconi. In the end code is compatible; we're just changing the endpoint that would be picked? And also that change really affects just the labs API, so it should be OK.
Dos this look like the way to go?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-199861554
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Ignasi Barrera <no...@github.com>.
This change *replaces* the current queuing service with the latest one, which is likely to be a backwards incompatible change. Does it make sense to also keep the marconi service type and just add zaqar? Would that make jclouds work with both versions?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-199204470
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [92e6319c](http://git-wip-us.apache.org/repos/asf/jclouds/commit/92e6319c). Thanks @fribeiro1!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-200274529
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Fernando Ribeiro <no...@github.com>.
I don't really think we need to keep the service type for Marconi, which wasn't included in any distribution before Liberty, for example, but the 1.0 API should continue to be supported as long as the Zaqar project maintains it.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-199247791
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Fernando Ribeiro <no...@github.com>.
I think so, and just amended the commit, please review.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#issuecomment-200036935
Re: [jclouds] JCLOUDS-1095: Update OpenStack KeyStone Support for
Zaqar (#938)
Posted by Ignasi Barrera <no...@github.com>.
Closed #938.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/938#event-600030623