You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2018/02/27 16:23:00 UTC
[GitHub] carbondata pull request #2008: [CARBONDATA-2211] in case of DDL HndOff shoul...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/2008
[CARBONDATA-2211] in case of DDL HndOff should not be execute in thread
If handoff triggered from DDL it should not execute in thread.
- [ ] Any interfaces changed? No
- [ ] Any backward compatibility impacted? No
- [ ] Document update required? No
- [ ] Testing done Manual testing Done
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-2211
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2008.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2008
----
commit eb3a536e88b6550d9e004aa6eeddc992168c16b9
Author: rahulforallp <ra...@...>
Date: 2018-02-27T16:20:20Z
[CARBONDATA-2211] in case of DDL HndOff should not be execute in thread
----
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2712/
---
[GitHub] carbondata pull request #2008: [CARBONDATA-2211] in case of DDL HndOff shoul...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2008#discussion_r171465697
--- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala ---
@@ -277,15 +277,21 @@ object StreamHandoffRDD {
*/
def startStreamingHandoffThread(
carbonLoadModel: CarbonLoadModel,
- sparkSession: SparkSession
+ sparkSession: SparkSession,
+ isDDL: Boolean
): Unit = {
// start a new thread to execute streaming segment handoff
val handoffThread = new Thread() {
--- End diff --
Done
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2763/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4007/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4000/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HandOff should not ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4010/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2008
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3713/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2008
please modify 'HndOff' to 'HandOff' in title.
---
[GitHub] carbondata pull request #2008: [CARBONDATA-2211] in case of DDL HndOff shoul...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2008#discussion_r171448904
--- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala ---
@@ -277,15 +277,21 @@ object StreamHandoffRDD {
*/
def startStreamingHandoffThread(
carbonLoadModel: CarbonLoadModel,
- sparkSession: SparkSession
+ sparkSession: SparkSession,
+ isDDL: Boolean
): Unit = {
// start a new thread to execute streaming segment handoff
val handoffThread = new Thread() {
--- End diff --
move this code to the inside of the if statement
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HandOff should not ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2766/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HandOff should not ...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2008
LGTM
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2756/
---
[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2008
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3957/
---
[GitHub] carbondata pull request #2008: [CARBONDATA-2211] in case of DDL HandOff shou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2008
---