You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by haohui <gi...@git.apache.org> on 2017/05/12 23:13:19 UTC
[GitHub] flink pull request #3890: [FLINK-6569] flink-table KafkaJsonTableSource exam...
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3890
[FLINK-6569] flink-table KafkaJsonTableSource example doesn't work.
This PR makes the proposed changes on the document and changes the Java unit tests to reflect the suggested usages of the API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-6569
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3890.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3890
----
commit f6f989d10abd2aa08ccdb73d946de21b631ebeea
Author: Haohui Mai <wh...@apache.org>
Date: 2017-05-12T23:12:19Z
[FLINK-6569] flink-table KafkaJsonTableSource example doesn't work.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3890
@haohui can you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3890
Thank you for addressing this so quickly.
+1 from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3890
The Java version of the API also depends on the Scala classes of `flink-table`. Everything in `org.apache.flink.table.api` is used in both languages. `org.apache.flink.table.api.scala/java` contain language specific classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3890: [FLINK-6569] flink-table KafkaJsonTableSource exam...
Posted by haohui <gi...@git.apache.org>.
Github user haohui closed the pull request at:
https://github.com/apache/flink/pull/3890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3890
My understanding is that the snippet should only depend on the Java version of the API (`ROW_NAMED` in flink-core) instead of the one written in Scala that resides in `flink-table`. Correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3890
-1
@haohui The examples are correct if you use Types class of the Table API: `org.apache.flink.table.api.Types`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---