You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/01 01:35:32 UTC
[GitHub] [hive] yongzhi commented on a change in pull request #1380: Show tables in database with owner policy
yongzhi commented on a change in pull request #1380:
URL: https://github.com/apache/hive/pull/1380#discussion_r480541081
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -5695,8 +5695,16 @@ private void alter_table_core(String catName, String dbname, String name, Table
String[] parsedDbName = parseDbName(dbname, conf);
try {
ret = getMS().getTables(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], pattern);
- ret = FilterUtils.filterTableNamesIfEnabled(isServerFilterEnabled, filterHook,
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ if(ret != null && !ret.isEmpty()) {
+ List<Table> tableInfo = new ArrayList<>();
+ tableInfo = getMS().getTableObjectsByName(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ tableInfo = FilterUtils.filterTablesIfEnabled(isServerFilterEnabled, filterHook, tableInfo);
+ List<String> result = new ArrayList<>(); // Cannot do ret.clear() because of query cannot be modified error in tests.
+ for (Table tbl : tableInfo) {
+ result.add(tbl.getTableName());
+ }
+ return result;
Review comment:
Better follow the same pattern as the original function, return at the end.
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -5695,8 +5695,16 @@ private void alter_table_core(String catName, String dbname, String name, Table
String[] parsedDbName = parseDbName(dbname, conf);
try {
ret = getMS().getTables(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], pattern);
- ret = FilterUtils.filterTableNamesIfEnabled(isServerFilterEnabled, filterHook,
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ if(ret != null && !ret.isEmpty()) {
+ List<Table> tableInfo = new ArrayList<>();
+ tableInfo = getMS().getTableObjectsByName(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ tableInfo = FilterUtils.filterTablesIfEnabled(isServerFilterEnabled, filterHook, tableInfo);
Review comment:
Please add comments on why you pass-in tableInfo objects
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java
##########
@@ -600,6 +600,22 @@ public void testReplDump() throws Exception {
assertEquals("table name", inDbTableName.toLowerCase(), dbObj.getObjectName());
}
+ @Test
+ public void showTablesInDB() throws Exception{
+ final String tableName1 = "table1";
+ driver.run("create table " + dbName+"."+tableName1 + "(eid int, yoj int)");
+ final String tableName2 = "table2";
+ driver.run("create table " + dbName+"."+tableName2 + "(eid int, ecode int)");
+ reset(mockedAuthorizer);
+
+ int status = driver.compile("show tables in "+dbName, true);
+ assertEquals(0, status);
+ Pair<List<HivePrivilegeObject>, List<HivePrivilegeObject>> io = getHivePrivilegeObjectInputs();
+ List<HivePrivilegeObject> inputs = io.getLeft();
+ HivePrivilegeObject dbObj = inputs.get(0);
+ assertEquals("input type", HivePrivilegeObjectType.DATABASE, dbObj.getType());
Review comment:
Is that possible also to assert on owner related values?
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -5695,8 +5695,16 @@ private void alter_table_core(String catName, String dbname, String name, Table
String[] parsedDbName = parseDbName(dbname, conf);
try {
ret = getMS().getTables(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], pattern);
- ret = FilterUtils.filterTableNamesIfEnabled(isServerFilterEnabled, filterHook,
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ if(ret != null && !ret.isEmpty()) {
+ List<Table> tableInfo = new ArrayList<>();
+ tableInfo = getMS().getTableObjectsByName(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ tableInfo = FilterUtils.filterTablesIfEnabled(isServerFilterEnabled, filterHook, tableInfo);
+ List<String> result = new ArrayList<>(); // Cannot do ret.clear() because of query cannot be modified error in tests.
Review comment:
Not quite understand the comment. Maybe ret = new ArrayList<>(); good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org