You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2022/03/28 05:15:48 UTC
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18363
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
IMPALA-11196 Fix a ClientCacheTest flaky test
The memory leak detection testcase is flaky, in local environment,
it could fail over 10 times out of 100. The fix changes to use
the ordinary ADD_BE_TEST to replace ADD_UNIFIED_BE_LSAN_TEST,
there could be some elements in the unified test which affect the
process vm size occasionally.
After the fix, the testcase ran 5000 times without a failure, and
can still catch the memory leak issue in IMPALA-11176.
Tests:
Ran Core Tests in DEBUG/RELEASE/ASAN build.
Ran consecutive 5000 times of the testcase and all passed.
Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
---
M be/src/runtime/CMakeLists.txt
M be/src/runtime/client-cache-test.cc
2 files changed, 17 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/18363/1
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 00:27:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 00:29:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7980/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 00:29:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7980/
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 04:58:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 22:07:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7983/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 17:38:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10343/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 05:35:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18363 )
Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test
......................................................................
IMPALA-11196 Fix a ClientCacheTest flaky test
The memory leak detection testcase is flaky, in local environment,
it could fail over 10 times out of 100. The fix changes to use
the ordinary ADD_BE_TEST to replace ADD_UNIFIED_BE_LSAN_TEST,
there could be some elements in the unified test which affect the
process vm size occasionally.
After the fix, the testcase ran 5000 times without a failure, and
can still catch the memory leak issue in IMPALA-11176.
Tests:
Ran Core Tests in DEBUG/RELEASE/ASAN build.
Ran consecutive 5000 times of the testcase and all passed.
Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Reviewed-on: http://gerrit.cloudera.org:8080/18363
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/CMakeLists.txt
M be/src/runtime/client-cache-test.cc
2 files changed, 17 insertions(+), 16 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ee273db4f9b0a518b6438df6982325f5ad1fa0c
Gerrit-Change-Number: 18363
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>