[GitHub] [ozone] linyiqun commented on pull request #1746: HDDS-4631. Fix client set quota with 0.

[GitBox <gi...@apache.org>]

linyiqun commented on pull request #1746:
URL: https://github.com/apache/ozone/pull/1746#issuecomment-753425854


   {quote}
   First we need to be able to distinguish whether the user sets quota to 0 (users may not specify Quoat when creating volumes and buckets, long is undefined as 0 by default and should be successful), and then judge the validity based on this.
   {quote}
   I don't fully get why we need to distinguish whether the user sets quota to 0. If the long undefined value is 0, we could return a Quota.RESET value instead of while get the quota value for this case. I don't think this is a problem here. And for other cases, we don't allow 0 could be set by cli command after above change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org