You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/11 10:18:46 UTC
[GitHub] [superset] ofekisr commented on a change in pull request #17400: refactor(ChartData): move chart_data_apis from ChartRestApi ChartDataRestApi
ofekisr commented on a change in pull request #17400:
URL: https://github.com/apache/superset/pull/17400#discussion_r747374866
##########
File path: superset/charts/api.py
##########
@@ -105,9 +99,6 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
RouteMethod.IMPORT,
RouteMethod.RELATED,
"bulk_delete", # not using RouteMethod since locally defined
- "data",
Review comment:
I move them to ChartDataRestApi to avoid duplications and mental confusion because that class should not aware that other are inherited it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org