[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29390: Fix grid logs for large logs

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #29390:
URL: https://github.com/apache/airflow/pull/29390#discussion_r1097790430


##########
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##########
@@ -47,11 +47,15 @@ export const parseLogs = (
     return {};
   }
   let lines;
+
+  let warning;
+
   try {
     lines = data.split('\n');
   } catch (err) {
     console.error(err);
-    return {};
+    warning = 'Unable to show logs. There was an error parsing logs.';

Review Comment:
   We might remove the `console.error` just above. eslint is complaining about it and now that the error is properly handled it's not required anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org