You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jonasof <gi...@git.apache.org> on 2017/04/21 16:36:37 UTC

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user jonasof commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
    Hello MeirBon and Gorebar,
    
    I make some improvements on your code, some are breaking changes to current behaviour:
    
    1. I add the  External Storage permissions to AndroidManifest.xml. because without this the plugin cannot ask for user permissions. Note that only people who need to make downloads will need this permission, and I don't know how to make this optional.
    2. I moved most download code to a new class named "InAppBrowserDownloads.java", because currently the user needs to click again do download after he authorizes file privileges. Using class proprieties this class saves the download url and other info and wait for the callback "onRequestPermissionResult", making the download right after user authorizes without need to click again. I also have changed the requester to "cordova.requestPermission" to use that callback, maybe this has compatibility problems with  older versions of cordova or cordova-android.
    3.  I changed the download folder to system default, instead of cache. In my smartphone is /Downloads in internal storage, like the browsers download folder.
    
    The commits are:
    1. https://github.com/jonasof/cordova-plugin-inappbrowser/commit/f0cc7c4ee7473fbda29cf9a51db362ff7380e0cf
    2. https://github.com/jonasof/cordova-plugin-inappbrowser/commit/aaaaa72880146f4c74d51d1379baef501e935ec5
    3. https://github.com/jonasof/cordova-plugin-inappbrowser/commit/4ea9e4f747d79cd6a97e49f5801b9177465bd3ab
    
    All commits diff: 
    https://github.com/MeirBon/cordova-plugin-inappbrowser/compare/download-permissions...jonasof:download-permissions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org