[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r563899594



##########
File path: cpp/src/arrow/array/util.h
##########
@@ -56,6 +56,14 @@ Result<std::shared_ptr<Array>> MakeArrayFromScalar(
 
 namespace internal {
 
+/// \brief Swap endian of each element in a generic ArrayData
+/// \param[in] data the array contents
+/// \param[in] type the array type
+/// \return the resulting Array instance whose elements were swapped
+ARROW_EXPORT
+Result<std::shared_ptr<ArrayData>> SwapEndianArrayData(
+    std::shared_ptr<ArrayData>& data, const std::shared_ptr<DataType>& type);
+
 /// Given a number of ArrayVectors, treat each ArrayVector as the

Review comment:
       Thank you for your comments. I will address it.
   
   Regarding the test, there are only integration tests as discussed at https://github.com/apache/arrow/pull/7507#issuecomment-657310102. I will add tests for `SwapEndianArrayData`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org