You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@apache.org> on 2020/10/12 14:16:57 UTC
Review Request 72954: Added suppressed roles to
`allocator/offer_constraints_debug` endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72954/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10177
https://issues.apache.org/jira/browse/MESOS-10177
Repository: mesos
Description
-------
This simplifies debugging frameworks that use offer constraints.
For example, in case a framework is not receiving offers for a role,
getting a suppressed roles snapshot simultaneously with agent
filtering results helps to figure out whether the framework is
mis-specifying offer constraints, or just wrongly suppresses a role.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 35264b9d866c9b95b76fccde5cf3b438e3bae160
Diff: https://reviews.apache.org/r/72954/diff/1/
Testing
-------
`make check`
Thanks,
Andrei Sekretenko
Re: Review Request 72954: Added suppressed roles to
`allocator/offer_constraints_debug` endpoint.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72954/#review222023
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72953, 72954]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Oct. 12, 2020, 2:16 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72954/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2020, 2:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This simplifies debugging frameworks that use offer constraints.
>
> For example, in case a framework is not receiving offers for a role,
> getting a suppressed roles snapshot simultaneously with agent
> filtering results helps to figure out whether the framework is
> mis-specifying offer constraints, or just wrongly suppresses a role.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 35264b9d866c9b95b76fccde5cf3b438e3bae160
>
>
> Diff: https://reviews.apache.org/r/72954/diff/2/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72954: Added suppressed roles to
`allocator/offer_constraints_debug` endpoint.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72954/#review222027
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.cpp
Lines 3311 (patched)
<https://reviews.apache.org/r/72954/#comment311099>
for (
- Benjamin Mahler
On Oct. 12, 2020, 2:16 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72954/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2020, 2:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This simplifies debugging frameworks that use offer constraints.
>
> For example, in case a framework is not receiving offers for a role,
> getting a suppressed roles snapshot simultaneously with agent
> filtering results helps to figure out whether the framework is
> mis-specifying offer constraints, or just wrongly suppresses a role.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 35264b9d866c9b95b76fccde5cf3b438e3bae160
>
>
> Diff: https://reviews.apache.org/r/72954/diff/2/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Andrei Sekretenko
>
>