You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/13 21:05:55 UTC

[GitHub] [airflow] abhilash1in commented on a change in pull request #10873: Add description field to connection (#10840)

abhilash1in commented on a change in pull request #10873:
URL: https://github.com/apache/airflow/pull/10873#discussion_r487577386



##########
File path: airflow/models/connection.py
##########
@@ -16,6 +16,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# pylint: disable=R0913

Review comment:
       Rule R0913 of `pylint` expected functions and methods to have utmost 10 arguments. The `__init__` method of `Connection` class already had 10 arguments. I added `description` which made it 11. So, had to disable rule R0913 and I followed the convention [here](https://github.com/apache/airflow/blob/9549274d110f689a0bd709db829a4d69e274eed9/airflow/providers/google/cloud/operators/dlp.py#L19). 
   
   Would it be better to replace `# pylint: disable=R0913` with `#pylint: disable=too-many-arguments` and add it at the end of the line `class Connection(Base, LoggingMixin):` instead of disabling the rule for the whole file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org