You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/10/27 10:30:47 UTC

[jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

https://issues.apache.org/jira/browse/JCLOUDS-761
You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds 761-eh-drive

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/587

-- Commit Summary --

  * JCLOUDS-761: Delete disk if image operation fails in ElasticStack

-- File Changes --

    M apis/elasticstack/src/main/java/org/jclouds/elasticstack/compute/ElasticStackComputeServiceAdapter.java (9)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/587.patch
https://github.com/jclouds/jclouds/pull/587.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1353](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1353/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60570105

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1869](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1869/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60573527

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1870](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1870/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60614800

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #264](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/264/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60569330

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by Ignasi Barrera <no...@github.com>.
>jclouds » jclouds #1870 UNSTABLE

Unrelated test failure

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60618087

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by Ignasi Barrera <no...@github.com>.
Squashed and pushed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c73ed64fd021fb64e2c7be7f00c2e3248ea5cc0f) and [1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=1df36e733d458a89bcefabf02cc45cfc47ee1fda).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60621214

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #265](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/265/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60607850

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1354](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1354/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60609393

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by Adrian Cole <ad...@gmail.com>.
:) thanks!

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by Ignasi Barrera <no...@github.com>.
>In a perfect world, would include a mock test.

Absolutely. And this is something we want, so I've added the corresponding test :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60604932

Re: [jclouds] JCLOUDS-761: Delete disk if imageDrive operation fails in ElasticStack (#587)

Posted by Adrian Cole <no...@github.com>.
Lgtm.

In a perfect world, would include a mock test.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/587#issuecomment-60590646