You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/06/01 19:58:41 UTC
Review Request 34897: CBO: Calcite Operator To Hive Operator (Calcite
Return Path) Empty tabAlias in columnInfo which triggers PPD
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34897/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, when aliases contains empty string "" and key is an empty string "" too, it assumes that aliases contains key. This will trigger incorrect PPD. To reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 4f19caf
Diff: https://reviews.apache.org/r/34897/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 34897: CBO: Calcite Operator To Hive Operator
(Calcite Return Path) Empty tabAlias in columnInfo which triggers PPD
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34897/#review87979
-----------------------------------------------------------
Pengcheng, I think many of the changes that you made are already included in HiveOpConverterPostProc.java (e.g. create the BaseSrc structure). We agreed we would use that rule for such things, as we may get rid of those data structures once we do the optimizations in Calcite, and that way it is easier to isolate the code.
Could you leave in the HiveOpConverter only the changes that are necessary?
- Jesús Camacho Rodríguez
On June 1, 2015, 5:58 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34897/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 5:58 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, when aliases contains empty string "" and key is an empty string "" too, it assumes that aliases contains key. This will trigger incorrect PPD. To reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 4f19caf
>
> Diff: https://reviews.apache.org/r/34897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 34897: CBO: Calcite Operator To Hive Operator
(Calcite Return Path) Empty tabAlias in columnInfo which triggers PPD
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34897/
-----------------------------------------------------------
(Updated June 17, 2015, 5:54 p.m.)
Review request for hive and Jesús Camacho Rodríguez.
Changes
-------
Address all the comments.
Repository: hive-git
Description
-------
in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, when aliases contains empty string "" and key is an empty string "" too, it assumes that aliases contains key. This will trigger incorrect PPD. To reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c21238
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java e7c8342
Diff: https://reviews.apache.org/r/34897/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 34897: CBO: Calcite Operator To Hive Operator
(Calcite Return Path) Empty tabAlias in columnInfo which triggers PPD
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34897/#review88242
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java (line 976)
<https://reviews.apache.org/r/34897/#comment140666>
Is your intention here to change the table alias in the schema of the child too?
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java (line 55)
<https://reviews.apache.org/r/34897/#comment140664>
It seems that joinOpToAlias is never used. Could it be removed?
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java (line 110)
<https://reviews.apache.org/r/34897/#comment140665>
Blank space
- Jesús Camacho Rodríguez
On June 16, 2015, 9:55 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34897/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:55 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, when aliases contains empty string "" and key is an empty string "" too, it assumes that aliases contains key. This will trigger incorrect PPD. To reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c21238
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java e7c8342
>
> Diff: https://reviews.apache.org/r/34897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 34897: CBO: Calcite Operator To Hive Operator
(Calcite Return Path) Empty tabAlias in columnInfo which triggers PPD
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34897/
-----------------------------------------------------------
(Updated June 16, 2015, 9:55 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, when aliases contains empty string "" and key is an empty string "" too, it assumes that aliases contains key. This will trigger incorrect PPD. To reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c21238
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java e7c8342
Diff: https://reviews.apache.org/r/34897/diff/
Testing
-------
Thanks,
pengcheng xiong