You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by stanton fisque <sf...@gmail.com> on 2022/04/28 15:32:59 UTC
want to provide patch
i'd like to provide a patch for some missing functionality, specifically the support handler for AverageIf (the generalized version is present but not the singular version). what is the best way to provide that? is there a repo where a pull request can be provided?
Stanton Fisque
principal technologist
latticeware.com
portland, oregon
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: want to provide patch
Posted by stanton fisque <sf...@gmail.com>.
yes. i figured that out after looking at the other PRs. the gitflow mech that i'm used to had us working on branches in the same repo, not forks. but after inspecting other PRs, the difference became apparent. PR has been submitted for review.
TIA
Stanton Fisque
principal technologist
latticeware.com
portland, oregon
> On Apr 28, 2022, at 23:33 PM, Dominik Stadler <do...@gmx.at> wrote:
>
> Hi,
>
> This is the default workflow of Github-repositories. You need to create a
> fork of the code into a new repository, create the branch there and then
> send a PR to the main repo.
>
> The following might help:
> *
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks
> *
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
> * https://gist.github.com/Chaser324/ce0505fbed06b947d962
>
> Dominik.
>
> On Fri, Apr 29, 2022 at 7:01 AM stanton fisque <sf...@gmail.com> wrote:
>
>> so i've cloned the repo, created a branch locally to make changes, added
>> the code and a corresponding unit test. but when i try to push back, i get
>> permission failure. it appears i cannot create a new branch, so that begs
>> the question, how does one submit a PR if they cannot create a feature
>> branch for the PR source.
>>
>>
>> Stanton Fisque
>> principal technologist
>> latticeware.com
>> portland, oregon
>>
>>> On Apr 28, 2022, at 09:00 AM, Nick Burch <ap...@gagravarr.org> wrote:
>>>
>>> On Thu, 28 Apr 2022, stanton fisque wrote:
>>>> i'd like to provide a patch for some missing functionality,
>> specifically the support handler for AverageIf (the generalized version is
>> present but not the singular version). what is the best way to provide
>> that? is there a repo where a pull request can be provided?
>>>
>>> Great! You'll want:
>>> * https://poi.apache.org/devel/guidelines.html
>>> * https://github.com/apache/poi
>>>
>>> For formula functions, see also
>>> * https://poi.apache.org/components/spreadsheet/eval.html
>>> *
>> http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
>>>
>>> Nick
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>>> For additional commands, e-mail: dev-help@poi.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: want to provide patch
Posted by Dominik Stadler <do...@gmx.at>.
Hi,
This is the default workflow of Github-repositories. You need to create a
fork of the code into a new repository, create the branch there and then
send a PR to the main repo.
The following might help:
*
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks
*
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
* https://gist.github.com/Chaser324/ce0505fbed06b947d962
Dominik.
On Fri, Apr 29, 2022 at 7:01 AM stanton fisque <sf...@gmail.com> wrote:
> so i've cloned the repo, created a branch locally to make changes, added
> the code and a corresponding unit test. but when i try to push back, i get
> permission failure. it appears i cannot create a new branch, so that begs
> the question, how does one submit a PR if they cannot create a feature
> branch for the PR source.
>
>
> Stanton Fisque
> principal technologist
> latticeware.com
> portland, oregon
>
> > On Apr 28, 2022, at 09:00 AM, Nick Burch <ap...@gagravarr.org> wrote:
> >
> > On Thu, 28 Apr 2022, stanton fisque wrote:
> >> i'd like to provide a patch for some missing functionality,
> specifically the support handler for AverageIf (the generalized version is
> present but not the singular version). what is the best way to provide
> that? is there a repo where a pull request can be provided?
> >
> > Great! You'll want:
> > * https://poi.apache.org/devel/guidelines.html
> > * https://github.com/apache/poi
> >
> > For formula functions, see also
> > * https://poi.apache.org/components/spreadsheet/eval.html
> > *
> http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
> >
> > Nick
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> > For additional commands, e-mail: dev-help@poi.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
Re: want to provide patch
Posted by stanton fisque <sf...@gmail.com>.
so i've cloned the repo, created a branch locally to make changes, added the code and a corresponding unit test. but when i try to push back, i get permission failure. it appears i cannot create a new branch, so that begs the question, how does one submit a PR if they cannot create a feature branch for the PR source.
Stanton Fisque
principal technologist
latticeware.com
portland, oregon
> On Apr 28, 2022, at 09:00 AM, Nick Burch <ap...@gagravarr.org> wrote:
>
> On Thu, 28 Apr 2022, stanton fisque wrote:
>> i'd like to provide a patch for some missing functionality, specifically the support handler for AverageIf (the generalized version is present but not the singular version). what is the best way to provide that? is there a repo where a pull request can be provided?
>
> Great! You'll want:
> * https://poi.apache.org/devel/guidelines.html
> * https://github.com/apache/poi
>
> For formula functions, see also
> * https://poi.apache.org/components/spreadsheet/eval.html
> * http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: want to provide patch
Posted by Nick Burch <ap...@gagravarr.org>.
On Thu, 28 Apr 2022, stanton fisque wrote:
> i'd like to provide a patch for some missing functionality, specifically
> the support handler for AverageIf (the generalized version is present
> but not the singular version). what is the best way to provide that?
> is there a repo where a pull request can be provided?
Great! You'll want:
* https://poi.apache.org/devel/guidelines.html
* https://github.com/apache/poi
For formula functions, see also
* https://poi.apache.org/components/spreadsheet/eval.html
* http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org