You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "MeihanLi (via GitHub)" <gi...@apache.org> on 2023/04/14 19:55:58 UTC

[GitHub] [pinot] MeihanLi commented on a diff in pull request #10614: [New Feature] Add new configuration options which allows broker to use a bounded Jersey ThreadPool

MeihanLi commented on code in PR #10614:
URL: https://github.com/apache/pinot/pull/10614#discussion_r1167228845


##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -148,6 +156,15 @@ public void processSqlQueryPost(String query, @Suspended AsyncResponse asyncResp
       BrokerResponse brokerResponse =
           executeSqlQuery((ObjectNode) requestJson, makeHttpIdentity(requestContext), false);
       asyncResponse.resume(brokerResponse.toJsonString());
+    } catch (ServiceUnavailableException e) {

Review Comment:
   Hi Ankit, yes, this is returning to the user. The RejectExecutionHandler in BrokerManagedAsyncExecutorProvider will throw a ServiceUnavailableException exception and can be caught here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org