You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "HaoYang670 (via GitHub)" <gi...@apache.org> on 2023/05/11 06:41:42 UTC
[GitHub] [kyuubi] HaoYang670 opened a new pull request, #4822: [KYUUBI #4280]Allow admin engine requests to pass in the session configuration.
HaoYang670 opened a new pull request, #4822:
URL: https://github.com/apache/kyuubi/pull/4822
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
For GROUP share level, Kyuubi will call `GroupProvider.primaryGroup` to get the group name. When create a Kyuubi Session, the `session config` is passed to the `primaryGroup`, however, in admin Engine requests, only the `fe.config` is passed to the `primaryGroup`, which is inconsistent.
This inconsistency would cause bugs when the logic in the `GroupProvider` is related to the Session config. So we need to update the admin engine requests to allow users to pass in the session config.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1550709072
Seems related
```
AdminResourceSuite:
- refresh Hadoop configuration of the kyuubi server
- refresh user defaults config of the kyuubi server
- refresh unlimited users of the kyuubi server
- list/close sessions
- list sessions/operations with filter
- list/close operations
- delete engine - user share level
- delete engine - group share level
- delete engine - group share level with SimpleGroupProvider *** FAILED ***
List() had size 0 instead of expected size 1 (AdminResourceSuite.scala:374)
- delete engine - connection share level
- list engine - user share level
- list engine - group share level
- list engine - group share level with SimpleGroupProvider *** FAILED ***
List() had size 0 instead of expected size 1 (AdminResourceSuite.scala:557)
- list engine - connection share level
- list server
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1193285391
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -212,14 +212,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
@QueryParam("type") engineType: String,
@QueryParam("sharelevel") shareLevel: String,
@QueryParam("subdomain") subdomain: String,
- @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String): Response = {
+ @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String,
+ request: AdminEngineRequest): Response = {
Review Comment:
It's feasible to use HadoopGroupProvider, w/ custom hadoop conf, but I would suggest implementing a SimpleGroupProvider(IIRC, we talked about this idea before)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #4820]Allow admin engine requests to pass in the group name. [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the group name.
URL: https://github.com/apache/kyuubi/pull/4822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1193578967
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -212,14 +212,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
@QueryParam("type") engineType: String,
@QueryParam("sharelevel") shareLevel: String,
@QueryParam("subdomain") subdomain: String,
- @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String): Response = {
+ @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String,
+ request: AdminEngineRequest): Response = {
Review Comment:
> is it possible to use Map[String, String] directly?
Yes. I've updated the code. Will add tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1550565719
I guess the test failures are not related to this PR. Hi @pan3793, could you please help to rerun the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the group name.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1550994491
Refactor to use QueryParam. But the test still fails because I don't find how to change the GroupProvider of fe.sessionmanager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the group name.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1197261945
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala:
##########
@@ -470,6 +520,57 @@ class AdminResourceSuite extends KyuubiFunSuite with RestFrontendTestHelper {
}
}
+ test("list engine - group share level with SimpleGroupProvider") {
+ val id = UUID.randomUUID().toString
+ conf.set(KyuubiConf.ENGINE_SHARE_LEVEL, GROUP.toString)
+ conf.set(KyuubiConf.ENGINE_TYPE, SPARK_SQL.toString)
+ conf.set(KyuubiConf.FRONTEND_THRIFT_BINARY_BIND_PORT, 0)
+ conf.set(HighAvailabilityConf.HA_NAMESPACE, "kyuubi_test")
+ conf.set(KyuubiConf.ENGINE_IDLE_TIMEOUT, 180000L)
+ conf.set(KyuubiConf.GROUP_PROVIDER, "org.apache.kyuubi.server.api.v1.SimpleGroupProvider")
+ conf.set("kyuubi.engine.group.name", "second")
+
+ val groupProvider = PluginLoader.loadGroupProvider(conf)
+
+ val engine =
+ new EngineRef(conf.clone, Utils.currentUser, groupProvider, id, null)
+
+ val engineSpace = DiscoveryPaths.makePath(
+ s"kyuubi_test_${KYUUBI_VERSION}_GROUP_SPARK_SQL",
+ groupProvider.primaryGroup(
+ Utils.currentUser,
+ conf.getAll.asJava),
+ "")
+
+ withDiscoveryClient(conf) { client =>
+ engine.getOrCreate(client)
+
+ assert(client.pathExists(engineSpace))
+ assert(client.getChildren(engineSpace).size == 1)
+
+ val response = webTarget.path("api/v1/admin/engine")
+ .queryParam("type", "spark_sql")
+ .queryParam("sharelevel", "GROUP")
+ .queryParam("groupname", "second")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .header(AUTHORIZATION_HEADER, s"BASIC $encodeAuthorization")
+ .get
Review Comment:
Hi @pan3793 could you please help me on how to change the `GroupProvider` of the server that the `get` request send to? It currently the uses `fe.sessionManager.groupProvider` which is the hadoop group provider, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1549270573
> Add UT
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1193578967
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -212,14 +212,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
@QueryParam("type") engineType: String,
@QueryParam("sharelevel") shareLevel: String,
@QueryParam("subdomain") subdomain: String,
- @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String): Response = {
+ @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String,
+ request: AdminEngineRequest): Response = {
Review Comment:
> is it possible to use Map[String, String] directly?
Yes. I've updated the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1193280142
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -212,14 +212,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
@QueryParam("type") engineType: String,
@QueryParam("sharelevel") shareLevel: String,
@QueryParam("subdomain") subdomain: String,
- @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String): Response = {
+ @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String,
+ request: AdminEngineRequest): Response = {
Review Comment:
> BTW, please add UT.
This would need a new `GroupProvider` for testing, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #4820]Allow admin engine requests to pass in the group name. [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-2800210761
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1550859145
Marked this draft because may be `QueryParam` is better than json body for a GET request. I will update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1193256654
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -212,14 +212,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
@QueryParam("type") engineType: String,
@QueryParam("sharelevel") shareLevel: String,
@QueryParam("subdomain") subdomain: String,
- @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String): Response = {
+ @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String,
+ request: AdminEngineRequest): Response = {
Review Comment:
is it possible to use `Map[String, String]` directly? BTW, please add UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1549139640
Hi @pan3793, I think we need to add integration tests for this as the REST API is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1547060779
Hi @pan3793 could you please help to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#discussion_r1193285391
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -212,14 +212,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
@QueryParam("type") engineType: String,
@QueryParam("sharelevel") shareLevel: String,
@QueryParam("subdomain") subdomain: String,
- @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String): Response = {
+ @QueryParam("hive.server2.proxy.user") hs2ProxyUser: String,
+ request: AdminEngineRequest): Response = {
Review Comment:
It's feasible to use HadoopGroupProvider, w/ custom hadoop conf, but I would suggest implementing a SimpleGroupProvider(IIRC, we talked about this idea before)
PS: Hadoop uses singleton in many places, if we decide to use HadoopGroupProvider in testing, should make sure clear and restore the context correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1543511526
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/4822?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4822](https://app.codecov.io/gh/apache/kyuubi/pull/4822?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d69d082) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/e112e381fff99f1d619185521edb064d88d35873?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e112e38) will **decrease** coverage by `0.02%`.
> The diff coverage is `27.27%`.
```diff
@@ Coverage Diff @@
## master #4822 +/- ##
============================================
- Coverage 58.01% 57.99% -0.02%
Complexity 13 13
============================================
Files 583 584 +1
Lines 32548 32582 +34
Branches 4317 4320 +3
============================================
+ Hits 18882 18897 +15
- Misses 11849 11864 +15
- Partials 1817 1821 +4
```
| [Impacted Files](https://app.codecov.io/gh/apache/kyuubi/pull/4822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/kyuubi/client/api/v1/dto/AdminEngineRequest.java](https://app.codecov.io/gh/apache/kyuubi/pull/4822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vQWRtaW5FbmdpbmVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/kyuubi/server/api/v1/AdminResource.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FkbWluUmVzb3VyY2Uuc2NhbGE=) | `84.84% <85.71%> (-0.25%)` | :arrow_down: |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/4822/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4822: [KYUUBI #4820]Allow admin engine requests to pass in the session configuration.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4822:
URL: https://github.com/apache/kyuubi/pull/4822#issuecomment-1550782273
Thank you @pan3793 for figuring this out. I am trying to debug it.
BTW, I find `listEngines` and `deleteEngine` are both defined in `AdminResource` and `AdminRestApi`. What's the relationship between them. Do I need to update all of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org