[GitHub] [incubator-dolphinscheduler] lenboo commented on issue #1489: fix issue:1477 some tasks would be running all the time when db delayed(#1477)

[GitBox <gi...@apache.org>]

lenboo commented on issue #1489: fix issue:1477 some tasks would be running all the time when db delayed(#1477)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1489#issuecomment-566039259
 
 
   > hi, @lenboo
   > 
   > Should the taskQueue.add (...) method be modified as well? In the current TaskQueueZkImpl # add () method, the error log is only printed after the exception is caught, and not thrown. This may cause the submitTaskToQueue () method to return true even if the task submission to zk fails.
   > 
   > I think the TaskQueueZkImpl.add (...) method should throw an exception directly instead of printing the log after catching it because it doesn't know how to handle this exception,
   
   yes, you are right, thank you for your reminder!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services