You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/09 13:40:21 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
eolivelli opened a new pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488
### Motivation
While running pulsar-broker tests I noticed that lots of threads named pulsar-transaction-buffer-client-timer-xxx are summing up, slowing consuming all of the resources of the host machine.
This change will be particularly helpful for CI and for downstream applications that start a PulsarBroken in unit tests. It is not a real problem in production as the server process is destroyed together with all of the internal threads.
### Modifications
Add "close" method to all relevant interfaces in order to allow PulsarService to shutdown the TransactionBufferHandlerImpl instance and the HashedWheelTimer inside.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488#issuecomment-724098037
Great work @eolivelli !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488#issuecomment-724099727
@lhotari FYI I see these are threads leaking:
broker-topic-workers
pulsar-web
bookkeeper-ml-workers
zk-cache-callback-executor
zk-cache-background
bookkeeper-ml-scheduler
broker-topic-workers
db-storage-cleanup
ledger-full-monitor
pulsar
pulsar-inactivity-monitor
pulsar-topic-publish-rate
it should be due to some PulsarService not shutdown properly, I am investigating, it takes a little time :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488#issuecomment-724026281
there are other resource leaks, I am sending small patches in order to ease review.
Currently the CI environment in suffering, in my opinion it is better to fix it.
@lhotari is doing at higher/CI layer
I am trying to address the issue from the bottom,
I guess we should have a better CI env soon
also the move of Pulsar Adapters out of the main repo (by @sijie ) is a good step forward
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli edited a comment on pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488#issuecomment-724020455
@lhotari @jiazhai @sijie @codelipenghui I guess this fix will help the execution of GitHub Actions.
Before this change if I run the tests on a small sized machine the execution consumes all of the resources of the machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8488: Transaction - fix TransactionBufferHandlerImpl thread leak in tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8488:
URL: https://github.com/apache/pulsar/pull/8488#issuecomment-724020455
@lhotari @jiazhai @codelipenghui I guess this fix will help the execution of GitHub Actions.
Before this change if I run the tests on a small sized machine the execution consumes all of the resources of the machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org