[jira] [Commented] (CB-7491) Bridge manual tests page crashes mobilespec app on windows platform

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140161#comment-14140161 ] 

ASF GitHub Bot commented on CB-7491:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-mobile-spec/pull/108

    CB-7491 Fixes bridge tests failure on windows

    Fix for https://issues.apache.org/jira/browse/CB-7491
    
    Issue is that test suite should contain at least one test spec otherwise reporter will fail.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-7491

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-mobile-spec/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 4cf2bad4bb762593afcc50c6fab55183219b3cac
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2014-09-09T11:42:52Z

    CB-7491 Fixes bridge tests failure on windows

----


> Bridge manual tests page crashes mobilespec app on windows platform
> -------------------------------------------------------------------
>
>                 Key: CB-7491
>                 URL: https://issues.apache.org/jira/browse/CB-7491
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: mobile-spec
>         Environment: Windows8/8.1/WP8.1 device
>            Reporter: Vladimir Kotikov
>              Labels: bridge, mobilespec, windows
>
> When user clicks on Non-plugin automatic tests -> Run bridge tests in mobilespec application on windows platform, app crashes. 
> Origin is {{reportSuiteResults()}} method in HtmlReporter, which tries to call method of {{reporterView}} object which is undefined since Bridge tests suite contains no specs (on windows) and due to this instance of {{reporterView}} is not created.
> Possible fix - add check for {{reporterView === undefined}} in {{reportSuiteResults}} method



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)