You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/01/24 18:01:29 UTC
[GitHub] DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 default provider if needed
DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628527
##########
File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
##########
@@ -80,9 +79,13 @@ private void enableSSL(final Hashtable<String, String> environment) {
private Hashtable<String, String> getEnvironment(final String principal, final String password, final String providerUrl, final boolean isSystemContext, Long domainId) {
final String factory = _ldapConfiguration.getFactory();
- final String url = providerUrl == null ? _ldapConfiguration.getProviderUrl(domainId) : providerUrl;
+ String url = providerUrl == null ? _ldapConfiguration.getProviderUrl(domainId) : providerUrl;
+ if (StringUtils.isEmpty(url) && domainId != null) {
Review comment:
we can but getProviderUrl(domainId) returns "" at least
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services