[GitHub] [pinot] Jackie-Jiang commented on issue #9290: Pinot Broker Uses a Generic "instanceId" Property Which is Shared With Minion

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on issue #9290:
URL: https://github.com/apache/pinot/issues/9290#issuecomment-1233297539

   Sounds good. Can you please file a PR for this?
   We may simplify it a little bit:
   ```
       _instanceId = _brokerConf.getProperty(Broker.CONFIG_OF_BROKER_ID);
       if (_instanceId == null) {
           _instanceId = _brokerConf.getProperty(Helix.Instance.INSTANCE_ID_KEY);
       }
       ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org