You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/09/06 20:14:26 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer

pan3793 commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r964128135


##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -33,7 +33,6 @@ class HiveSessionImpl(
     protocol: TProtocolVersion,
     user: String,
     password: String,
-    serverIpAddress: String,

Review Comment:
   this change may breaks https://github.com/apache/incubator-kyuubi/pull/1530/files#diff-759a09fe90c07b0ef78f6f4dc28bac9e3d0785d4b922cbe33422524e8a2520d4R51



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org