You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by barney2k7 <gi...@git.apache.org> on 2016/10/28 08:59:39 UTC
[GitHub] wicket pull request #185: TimeZone handling in examples: apply settings clie...
GitHub user barney2k7 opened a pull request:
https://github.com/apache/wicket/pull/185
TimeZone handling in examples: apply settings client time zone on DateFormat
DateFormat previously used the jvm's default time zone, which leads to somewhat confusing output on the example page: 'Based on your settings, your time is: 4:46:15 AM EDT (and your time zone is Central European Time)'
After this patch, it shows '10:57:49 AM CEST (and your time zone is Central European Time)' (jvm's default time zone no longer relevant)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barney2k7/wicket examples-timezone
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 158a5ba8ce966686c05116d78d8040e06efe6d22
Author: barney2k7 <ba...@gmail.com>
Date: 2016-10-28T08:46:54Z
settings client time zone on DateFormat
DateFormat would otherwise use the jvm's default time zone, e.g.
'4:46:15 AM EDT (and your time zone is Central European Time)'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #185: TimeZone handling in examples: apply settings client time...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/185
+1 to merge.
@martin-g - WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #185: TimeZone handling in examples: apply settings client time...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/185
Thank you, @barney2k7 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #185: TimeZone handling in examples: apply settings clie...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---