You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "julianhyde (via GitHub)" <gi...@apache.org> on 2026/03/01 01:57:52 UTC
[PR] [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted [calcite]
julianhyde opened a new pull request, #4813:
URL: https://github.com/apache/calcite/pull/4813
See CALCITE-7424.
This is a prerequisite for CALCITE-7420, because we want rule tests to be sorted by test name within each `.iq` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted [calcite]
Posted by "julianhyde (via GitHub)" <gi...@apache.org>.
julianhyde commented on PR #4813:
URL: https://github.com/apache/calcite/pull/4813#issuecomment-3979458432
Thanks for your review, @xiedeyantu. I have made the changes you suggested, and have merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted [calcite]
Posted by "julianhyde (via GitHub)" <gi...@apache.org>.
julianhyde closed pull request #4813: [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted
URL: https://github.com/apache/calcite/pull/4813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4813:
URL: https://github.com/apache/calcite/pull/4813#issuecomment-3978886027
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4813) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4813&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4813&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4813&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4813&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4813&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4813)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4813:
URL: https://github.com/apache/calcite/pull/4813#discussion_r2868417492
##########
core/src/test/java/org/apache/calcite/test/LintTest.java:
##########
@@ -497,23 +548,6 @@ private static void checkMessage(String subject, String body,
}
}
- /** Ensures that the {@code contributors.yml} file is sorted by name. */
- @Test void testContributorsFileIsSorted() throws IOException {
- final ObjectMapper mapper = new YAMLMapper();
- final File contributorsFile = ROOT_PATH.resolve("site/_data/contributors.yml").toFile();
- JavaType listType =
- mapper.getTypeFactory()
- .constructCollectionType(List.class, Contributor.class);
- List<Contributor> contributors =
- mapper.readValue(contributorsFile, listType);
- Contributor contributor =
- firstOutOfOrder(contributors,
- Comparator.comparing(c -> c.name, String.CASE_INSENSITIVE_ORDER));
- if (contributor != null) {
- fail("contributor '" + contributor.name + "' is out of order");
- }
- }
-
/** Ensures that the {@code .mailmap} file is sorted. */
@Test void testMailmapFile() {
Review Comment:
Could this case have been forgotten to be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7424] LintTest should check that files marked with '// lint: sort' are sorted [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4813:
URL: https://github.com/apache/calcite/pull/4813#issuecomment-3979098164
Please remember to make the Jira title, PR title, and commit message consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org