[GitHub] mik-laj commented on a change in pull request #2455: [AIRFLOW-1423] Add logs to the scheduler DAG run decision logic

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #2455: [AIRFLOW-1423] Add logs to the scheduler DAG run decision logic
URL: https://github.com/apache/airflow/pull/2455#discussion_r240830440
 
 

 ##########
 File path: airflow/jobs.py
 ##########
 @@ -786,6 +788,9 @@ def create_dag_run(self, dag, session=None):
             )
             # return if already reached maximum active runs and no timeout setting
             if len(active_runs) >= dag.max_active_runs and not dag.dagrun_timeout:
+                self.logger.info(
+                    "Dag reached maximum of {} active runs (no timeout)".
 
 Review comment:
   Such formatting of messages causes that a string object is created, which then may not be used anywhere, when the login level will be too low.
   Formatting parameters should be passed as arguments to the `info` method.
   Example:
   
   ````python
   self.log.info("The Table '%s' does not exists already.", self.table_id)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services