You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/08/22 01:46:04 UTC
[kudu-CR](branch-1.17.x) KUDU-3432: Fix flakiness in client-test.cc
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20388
Change subject: KUDU-3432: Fix flakiness in client-test.cc
......................................................................
KUDU-3432: Fix flakiness in client-test.cc
The 'TestGetTableKeyRange' in 'client-test.cc' may
be unstable in certain cases. Through analysis, it
was determined that the split algorithm might encounter
some corner cases when handling written data.
To mitigate the impact of these cases on CI, I have
increased the amount of data written in the unit tests
and modified some logic in dance to enhance the robustness
of the unit tests.
Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Reviewed-on: http://gerrit.cloudera.org:8080/20314
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit acd1622b0c77b40280753567130a815cbcd93081)
---
M src/kudu/client/client-test.cc
1 file changed, 22 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/20388/1
--
To view, visit http://gerrit.cloudera.org:8080/20388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Gerrit-Change-Number: 20388
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
[kudu-CR](branch-1.17.x) KUDU-3432: Fix flakiness in client-test.cc
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20388 )
Change subject: KUDU-3432: Fix flakiness in client-test.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Gerrit-Change-Number: 20388
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 23 Aug 2023 02:38:16 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3432: Fix flakiness in client-test.cc
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20388 )
Change subject: KUDU-3432: Fix flakiness in client-test.cc
......................................................................
KUDU-3432: Fix flakiness in client-test.cc
The 'TestGetTableKeyRange' in 'client-test.cc' may
be unstable in certain cases. Through analysis, it
was determined that the split algorithm might encounter
some corner cases when handling written data.
To mitigate the impact of these cases on CI, I have
increased the amount of data written in the unit tests
and modified some logic in dance to enhance the robustness
of the unit tests.
Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Reviewed-on: http://gerrit.cloudera.org:8080/20314
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit acd1622b0c77b40280753567130a815cbcd93081)
Reviewed-on: http://gerrit.cloudera.org:8080/20388
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 22 insertions(+), 29 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Gerrit-Change-Number: 20388
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) KUDU-3432: Fix flakiness in client-test.cc
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20388 )
Change subject: KUDU-3432: Fix flakiness in client-test.cc
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Gerrit-Change-Number: 20388
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 22 Aug 2023 17:34:22 +0000
Gerrit-HasComments: No