You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/01 23:16:54 UTC

[GitHub] [incubator-superset] bkyryliuk commented on pull request #10208: feat: support nulls in the csv uploads

bkyryliuk commented on pull request #10208:
URL: https://github.com/apache/incubator-superset/pull/10208#issuecomment-652690893


   > mostly lgtm
   > 
   > Are integer columns affected by this change at all? I'm not sure how we deal with null integers in csv upload.
   
   Thanks @serenajiang for the review
   Mysql recognized the column as double and wrote null
   ![image](https://user-images.githubusercontent.com/5727938/86299032-0e800600-bbb4-11ea-9727-e7635850e5c4.png)
   
   Hive:
   int + null value
   ![image](https://user-images.githubusercontent.com/5727938/86299885-3bcdb380-bbb6-11ea-8f5e-0cbb25faf652.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org