You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/03/28 20:30:08 UTC
Review Request 66323: Added tests for failed task launch on agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
This test verifies the agent behavior of launching
two task(group)s using the same executor. When both
tasks are launching on the agent (before creating
any executor), if the first task (in the agent receiving
order) fails to launch, the later task will get dropped.
If the later task fails to launch, the first task
should still launch successfully.
Diffs
-----
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66323/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200419
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 66346, 66145, 66178, 66323]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 4, 2018, 3:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 3:32 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200581
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 4, 2018, 3:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 3:32 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200582
-----------------------------------------------------------
src/tests/slave_tests.cpp
Lines 5407 (patched)
<https://reviews.apache.org/r/66323/#comment281326>
Capture by value. Here and below.
src/tests/slave_tests.cpp
Lines 5609 (patched)
<https://reviews.apache.org/r/66323/#comment281327>
Capture by value.
- Greg Mann
On April 4, 2018, 3:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 3:32 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200417
-----------------------------------------------------------
PASS: Mesos patch 66323 was successfully built and tested.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66322', '66144', '66346', '66145', '66178', '66323']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66323
- Mesos Reviewbot Windows
On April 4, 2018, 3:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 3:32 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/
-----------------------------------------------------------
(Updated April 5, 2018, 5:36 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
set expectations in the right order.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
These tests verify the agent behavior of launching
several task groups using the same executor. When
task groups are launching on the agent (before creating
any executor), if the first received task group
fails to launch, later task groups will get dropped.
If a later received task group fails to launch, the first
received task group should still launch successfully.
Diffs (updated)
-----
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66323/diff/8/
Changes: https://reviews.apache.org/r/66323/diff/7-8/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/
-----------------------------------------------------------
(Updated April 3, 2018, 8:32 p.m.)
Review request for mesos and Greg Mann.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description (updated)
-------
These tests verify the agent behavior of launching
several task groups using the same executor. When
task groups are launching on the agent (before creating
any executor), if the first received task group
fails to launch, later task groups will get dropped.
If a later received task group fails to launch, the first
received task group should still launch successfully.
Diffs (updated)
-----
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66323/diff/4/
Changes: https://reviews.apache.org/r/66323/diff/3-4/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On April 3, 2018, 5:17 p.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5249 (patched)
> > <https://reviews.apache.org/r/66323/diff/3/?file=1990632#file1990632line5249>
> >
> > Is this necessary?
To avoid uninteresting mock calls.
> On April 3, 2018, 5:17 p.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5251-5252 (patched)
> > <https://reviews.apache.org/r/66323/diff/3/?file=1990632#file1990632line5251>
> >
> > Is this needed?
To avoid uninteresting mock calls.
> On April 3, 2018, 5:17 p.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5456-5457 (patched)
> > <https://reviews.apache.org/r/66323/diff/3/?file=1990632#file1990632line5456>
> >
> > Is this needed?
To avoid uninteresting mock call.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
-----------------------------------------------------------
On April 3, 2018, 8:32 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 8:32 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 4, 2018, 12:17 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5251-5252 (patched)
> > <https://reviews.apache.org/r/66323/diff/3/?file=1990632#file1990632line5251>
> >
> > Is this needed?
>
> Meng Zhu wrote:
> To avoid uninteresting mock calls.
The real question here is WHY does this method get called on the scheduler? The `failure()` method is invoked whenever an `Event::FAILURE` is received by the test v1 scheduler. I didn't realize it, but it turns out we evolve the `ExitedExecutorMessage` into an `Event::FAILURE` for v1 schedulers: https://github.com/apache/mesos/blob/594ee20c2453dad836313769aef9f8655cd75cd5/src/internal/evolve.cpp#L294-L305
So the exiting executor in this test explains why that method is invoked. However, I don't understand why it would be invoked twice, since we only have one executor here? I wonder if we're executing some cleanup logic for the failed task twice? It's also possible that the event is sent when the agent is removed at the end of the test, but I don't recall running into this in other tests.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
-----------------------------------------------------------
On April 4, 2018, 3:32 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 3:32 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On April 3, 2018, 5:17 p.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5251-5252 (patched)
> > <https://reviews.apache.org/r/66323/diff/3/?file=1990632#file1990632line5251>
> >
> > Is this needed?
>
> Meng Zhu wrote:
> To avoid uninteresting mock calls.
>
> Greg Mann wrote:
> The real question here is WHY does this method get called on the scheduler? The `failure()` method is invoked whenever an `Event::FAILURE` is received by the test v1 scheduler. I didn't realize it, but it turns out we evolve the `ExitedExecutorMessage` into an `Event::FAILURE` for v1 schedulers: https://github.com/apache/mesos/blob/594ee20c2453dad836313769aef9f8655cd75cd5/src/internal/evolve.cpp#L294-L305
>
> So the exiting executor in this test explains why that method is invoked. However, I don't understand why it would be invoked twice, since we only have one executor here? I wonder if we're executing some cleanup logic for the failed task twice? It's also possible that the event is sent when the agent is removed at the end of the test, but I don't recall running into this in other tests.
Changed to `atmost(1)`
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
-----------------------------------------------------------
On April 3, 2018, 8:32 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 8:32 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
-----------------------------------------------------------
src/tests/slave_tests.cpp
Lines 5208 (patched)
<https://reviews.apache.org/r/66323/#comment281126>
This test does actually launch task groups, so maybe:
s/task(group)s/task groups/
here and below.
src/tests/slave_tests.cpp
Lines 5210 (patched)
<https://reviews.apache.org/r/66323/#comment281127>
s/first task (in the agent receiving order)/first received task/
here and below.
src/tests/slave_tests.cpp
Lines 5212 (patched)
<https://reviews.apache.org/r/66323/#comment281129>
s/TasksLaunch/LaunchTasks/
src/tests/slave_tests.cpp
Lines 5220 (patched)
<https://reviews.apache.org/r/66323/#comment281130>
Could you move this down above the site of its first use?
src/tests/slave_tests.cpp
Lines 5249 (patched)
<https://reviews.apache.org/r/66323/#comment281138>
Is this necessary?
src/tests/slave_tests.cpp
Lines 5251-5252 (patched)
<https://reviews.apache.org/r/66323/#comment281139>
Is this needed?
src/tests/slave_tests.cpp
Lines 5272 (patched)
<https://reviews.apache.org/r/66323/#comment281142>
Looks like this could be just `executorInfo`? Here and below.
src/tests/slave_tests.cpp
Lines 5275 (patched)
<https://reviews.apache.org/r/66323/#comment281144>
s/two/three/
Also, I would add a newline after this comment, since it applies to multiple blocks of code below.
src/tests/slave_tests.cpp
Lines 5317 (patched)
<https://reviews.apache.org/r/66323/#comment281145>
s/both/all/
src/tests/slave_tests.cpp
Lines 5320-5344 (patched)
<https://reviews.apache.org/r/66323/#comment281161>
As discussed in chat, here we're making the assumption that the first invocation of `_run()` corresponds to `taskGroup1`, which is not necessarily true. Let's make use of your matchers to address this, here and below.
src/tests/slave_tests.cpp
Lines 5348-5349 (patched)
<https://reviews.apache.org/r/66323/#comment281153>
Indent two more spaces.
src/tests/slave_tests.cpp
Lines 5351 (patched)
<https://reviews.apache.org/r/66323/#comment281149>
Let's split this into 3 separate AWAIT_READY calls.
src/tests/slave_tests.cpp
Lines 5364 (patched)
<https://reviews.apache.org/r/66323/#comment281154>
I would either do
s/taskgroup1/`taskGroup1`/
or
s/taskgroup1/task group 1/
here and below.
src/tests/slave_tests.cpp
Lines 5365 (patched)
<https://reviews.apache.org/r/66323/#comment281155>
As discussed in chat, let's capture by value here and elsewhere.
src/tests/slave_tests.cpp
Lines 5447 (patched)
<https://reviews.apache.org/r/66323/#comment281156>
Let's put the `.WillOnce` on a new line for consistency.
src/tests/slave_tests.cpp
Lines 5456-5457 (patched)
<https://reviews.apache.org/r/66323/#comment281157>
Is this needed?
src/tests/slave_tests.cpp
Lines 5506 (patched)
<https://reviews.apache.org/r/66323/#comment281158>
Indented too far.
src/tests/slave_tests.cpp
Lines 5537 (patched)
<https://reviews.apache.org/r/66323/#comment281159>
Indent two more spaces.
src/tests/slave_tests.cpp
Lines 5539 (patched)
<https://reviews.apache.org/r/66323/#comment281160>
Let's split this into 2 AWAIT_READY calls.
- Greg Mann
On March 30, 2018, 6:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated March 30, 2018, 6:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies the agent behavior of launching
> two task(group)s using the same executor. When both
> tasks are launching on the agent (before creating
> any executor), if the first task (in the agent receiving
> order) fails to launch, the later task will get dropped.
> If the later task fails to launch, the first task
> should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/
-----------------------------------------------------------
(Updated March 30, 2018, 11:10 a.m.)
Review request for mesos and Greg Mann.
Changes
-------
Added one task, three tasks instead of two to cover more corner cases.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
This test verifies the agent behavior of launching
two task(group)s using the same executor. When both
tasks are launching on the agent (before creating
any executor), if the first task (in the agent receiving
order) fails to launch, the later task will get dropped.
If the later task fails to launch, the first task
should still launch successfully.
Diffs (updated)
-----
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66323/diff/3/
Changes: https://reviews.apache.org/r/66323/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66323: Added tests for failed task launch on agent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200154
-----------------------------------------------------------
PASS: Mesos patch 66323 was successfully built and tested.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66322', '66144', '66145', '66178', '66323']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66323
- Mesos Reviewbot Windows
On March 28, 2018, 8:30 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 8:30 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies the agent behavior of launching
> two task(group)s using the same executor. When both
> tasks are launching on the agent (before creating
> any executor), if the first task (in the agent receiving
> order) fails to launch, the later task will get dropped.
> If the later task fails to launch, the first task
> should still launch successfully.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66323/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>