You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/08 06:50:15 UTC

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #5102: if more rule decorate metaData bug fix.

yu199195 opened a new pull request #5102: if more rule decorate metaData bug fix.
URL: https://github.com/apache/incubator-shardingsphere/pull/5102
 
 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5102: if more rule decorate metaData bug fix.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5102: if more rule decorate metaData bug fix.
URL: https://github.com/apache/incubator-shardingsphere/pull/5102#discussion_r405374419
 
 

 ##########
 File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
 ##########
 @@ -146,8 +146,10 @@ private SchemaMetaData decorate(final SchemaMetaData schemaMetaData) {
         Map<String, TableMetaData> result = new HashMap<>(schemaMetaData.getAllTableNames().size(), 1);
         Map<BaseRule, RuleMetaDataDecorator> decorators = OrderedSPIRegistry.getRegisteredServices(rules, RuleMetaDataDecorator.class);
         for (String each : schemaMetaData.getAllTableNames()) {
+            TableMetaData decorate = null;
 
 Review comment:
   Please do not use verb as a variable name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5102: if more rule decorate metaData bug fix.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5102: if more rule decorate metaData bug fix.
URL: https://github.com/apache/incubator-shardingsphere/pull/5102
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5102: if more rule decorate metaData bug fix.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5102: if more rule decorate metaData bug fix.
URL: https://github.com/apache/incubator-shardingsphere/pull/5102#issuecomment-610831727
 
 
   ## Pull Request Test Coverage Report for [Build 10884](https://coveralls.io/builds/29932050)
   
   * **0** of **3**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.006%**) to **57.294%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java](https://coveralls.io/builds/29932050/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fmetadata%2Fschema%2FRuleSchemaMetaDataLoader.java#L149) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **3** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29932050/badge)](https://coveralls.io/builds/29932050) |
   | :-- | --: |
   | Change from base [Build 10882](https://coveralls.io/builds/29930206): |  -0.006% |
   | Covered Lines: | 11668 |
   | Relevant Lines: | 20365 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 commented on a change in pull request #5102: if more rule decorate metaData bug fix.

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5102: if more rule decorate metaData bug fix.
URL: https://github.com/apache/incubator-shardingsphere/pull/5102#discussion_r405414605
 
 

 ##########
 File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
 ##########
 @@ -146,8 +146,10 @@ private SchemaMetaData decorate(final SchemaMetaData schemaMetaData) {
         Map<String, TableMetaData> result = new HashMap<>(schemaMetaData.getAllTableNames().size(), 1);
         Map<BaseRule, RuleMetaDataDecorator> decorators = OrderedSPIRegistry.getRegisteredServices(rules, RuleMetaDataDecorator.class);
         for (String each : schemaMetaData.getAllTableNames()) {
+            TableMetaData decorate = null;
 
 Review comment:
   fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5102: if more rule decorate metaData bug fix.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5102: if more rule decorate metaData bug fix.
URL: https://github.com/apache/incubator-shardingsphere/pull/5102#discussion_r405378336
 
 

 ##########
 File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
 ##########
 @@ -146,8 +146,10 @@ private SchemaMetaData decorate(final SchemaMetaData schemaMetaData) {
         Map<String, TableMetaData> result = new HashMap<>(schemaMetaData.getAllTableNames().size(), 1);
         Map<BaseRule, RuleMetaDataDecorator> decorators = OrderedSPIRegistry.getRegisteredServices(rules, RuleMetaDataDecorator.class);
         for (String each : schemaMetaData.getAllTableNames()) {
+            TableMetaData decorate = null;
 
 Review comment:
   Use result to get meta data is better than use null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services