You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "if0ne (via GitHub)" <gi...@apache.org> on 2026/01/15 13:23:16 UTC
[PR] feat: add redirection handling [arrow-rs-object-store]
if0ne opened a new pull request, #607:
URL: https://github.com/apache/arrow-rs-object-store/pull/607
# Which issue does this PR close?
Closes #603
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add redirection handling [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #607:
URL: https://github.com/apache/arrow-rs-object-store/pull/607#issuecomment-3762943121
> Yes, this will break authentication.
This feels like Nvidia AIStore is doing something that fundamentally isn't S3-Compatible then.
> I’m not sure, but as far as I know, this auth header-handling logic is implemented in reqwest.
reqwest just sends whatever headers it is given, if this Nvidia AIStore thing is relying on redirects (which is dubious to then claim is S3-compatible - see above), its unclear whether the redirected request should then contain the URL or not.
I'm NGL I am leaning to it being better for you to just implement a custom ObjectStore for this, fundamentally this product doesn't really appear to be S3-compatible...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add redirection handling [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #607: feat: add redirection handling
URL: https://github.com/apache/arrow-rs-object-store/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add redirection handling [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #607:
URL: https://github.com/apache/arrow-rs-object-store/pull/607#issuecomment-3762078364
Thinking a bit more about this, isn't this ill-formed when it comes to authentication? Both S3 and Azure (sometimes) rely on request signing which encodes the request URL in the signature - doesn't a redirect break this? Should the redirect even carry the authentication header?
Perhaps this instead this could be implemented as a custom [HttpClient](https://docs.rs/object_store/0.12.4/object_store/client/struct.HttpClient.html)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add redirection handling [arrow-rs-object-store]
Posted by "if0ne (via GitHub)" <gi...@apache.org>.
if0ne commented on PR #607:
URL: https://github.com/apache/arrow-rs-object-store/pull/607#issuecomment-3762939918
Yes, this will break authentication. In any case, the request won’t go through—either because of a 307 or a 401. A more complicated solution is needed here, so that the provider itself can decide how to handle redirects.
> Should the redirect even carry the authentication header?
I’m not sure, but as far as I know, this auth header-handling logic is implemented in reqwest.
> Perhaps this instead could be implemented as a custom HttpClient?
I’d be glad to know which HTTP client correctly handles redirecting a request body to a different URI. I tried implementing this with `ureq`, but that client also does not redirect the request body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add redirection handling [arrow-rs-object-store]
Posted by "if0ne (via GitHub)" <gi...@apache.org>.
if0ne commented on PR #607:
URL: https://github.com/apache/arrow-rs-object-store/pull/607#issuecomment-3762953373
Thanks you. I wanted to keep it simple and avoid implementing an entire provider for AiStore, but it looks like I’ll have to…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org