You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2014/06/17 07:13:02 UTC

[jira] [Updated] (HADOOP-10713) Document thread-safety of CryptoCodec#generateSecureRandom

     [ https://issues.apache.org/jira/browse/HADOOP-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Wang updated HADOOP-10713:
---------------------------------

    Attachment: HADOOP-10713.001.patch

Trivial patch attached. While I was looking at this, I also wondered whether this API should be like {{SecureRandom#nextBytes(byte[])}}, taking a {{byte[]}}, rather than taking an int numBytes and returning a new array. [~hitliuyi] any thoughts? It might save us some allocations.

> Document thread-safety of CryptoCodec#generateSecureRandom
> ----------------------------------------------------------
>
>                 Key: HADOOP-10713
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10713
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-10713.001.patch
>
>
> Random implementations have to deal with thread-safety; this should be specified in the javadoc so implementors know to do this for CryptoCodec subclasses.



--
This message was sent by Atlassian JIRA
(v6.2#6252)