[GitHub] [hadoop-ozone] supratimdeka commented on a change in pull request #628: HDDS-1008. Invalidate closed container replicas on a failed volume.

[GitBox <gi...@apache.org>]

supratimdeka commented on a change in pull request #628: HDDS-1008. Invalidate closed container replicas on a failed volume.
URL: https://github.com/apache/hadoop-ozone/pull/628#discussion_r387661719
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
 ##########
 @@ -298,6 +298,8 @@ public void markContainerForClose() throws StorageContainerException {
   public void markContainerUnhealthy() throws StorageContainerException {
     writeLock();
     try {
+      // TODO: container should be marked UNHEALTHY in memory even if container
 
 Review comment:
   Good point. But, I think this is how it is already implemented. updateContainerData() on encountering an exception, does not reset the state if the state is UNHEALTHY. Or did I get that wrong?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org