[GitHub] [hudi] yihua commented on a diff in pull request #6311: [HUDI-4548] Unpack the column max/min to string instead of Utf8 for M…

[GitBox <gi...@apache.org>]

yihua commented on code in PR #6311:
URL: https://github.com/apache/hudi/pull/6311#discussion_r939429766


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -134,14 +134,14 @@ class ColumnStats {
 
     HashMap<String, ColumnStats> allColumnStats = new HashMap<>();
 
-    // Collect stats for all columns by iterating through records while accounting
-    // corresponding stats
-    records.forEach((record) -> {
-      // For each column (field) we have to index update corresponding column stats
-      // with the values from this record
-      targetFields.forEach(field -> {
-        ColumnStats colStats = allColumnStats.computeIfAbsent(field.name(), (ignored) -> new ColumnStats());
-
+    // For each column (field) we have to index update corresponding column stats
+    // with the values from this record
+    targetFields.forEach(field -> {

Review Comment:
   @danny0405 shall we keep the code as before?  Doesn't look like the logic changes anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org